Check OIDC token type and return 401 for invalid bearer tokens #10811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10717
This PR:
In fact, even without this PR, the test would get
403
because RT would have no expected roles (403 in this case is not issued byquarkus-oidc
but by the follow up roles checker), but the correct response is not even get the RBAC layer exercised and return 401 immediately since the token is invalid.BearerAuthenticationMechanism
, the challenge should really be401
all the time,403
implies that the actual token is valid (signature, different verification constraints), only roles are not matching but RBAC is not even enforced yet by the time Challenge is made so it should be401