Re-subscription must re-trigger the operation #10810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it something that should go in 1.6.1? |
|
BTW, I believe that the Resteasy Single/Maybe support has the same bug. |
FroMage
approved these changes
Jul 20, 2020
|
Yes, it deserves to be mentioned in the doc. I will add a sentence tomorrow. |
When an operation returns a Uni, resubscribing to this Uni must re-execute the underlying operation (except if the user explicitly uses cache()). As RestEasy uses CompletionStage behind the scene, this behavior was not working and was always returning the same CompletionStage (the initial one). As a consequence, resubscriptions and retries were not working. This commit changes how the Unis are created to re-execute the operation on every subscription. Note that it also delays the initial execution until the first subscription.
cescoffier
force-pushed
the
features/resubscription-must-reexecute-operation
branch
from
866f264 to
6ff0c0a
Compare
|
@FroMage I've added a bit of text in the documentation. |
FroMage
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an operation returns a Uni, resubscribing to this Uni must re-execute the underlying operation (except if the user explicitly uses cache()).
As RestEasy uses CompletionStage behind the scene, this behavior was not working and was always returning the same CompletionStage (the initial one). As a consequence, resubscriptions and retries were not working.
This PR changes how the Unis are created to re-execute the operation on every subscription. Note that it also delays the initial execution until the first subscription.