Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the OIDC/OAuth2 documentation #10715

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

sberyozkin
Copy link
Member

@gastaldi Hi George, I had to remove this line, as it was already included in the security-oidc-connect-web-authentication.
The original PR was already approved by @loicmathieu and @pedroigor, so if you and @gsmet have no other comments, it should be good to go again once the build passes.

@sberyozkin sberyozkin added this to the 1.7.0 - master milestone Jul 14, 2020
@sberyozkin sberyozkin requested review from gastaldi and gsmet July 14, 2020 11:12
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch @sberyozkin !

@gastaldi gastaldi merged commit b22e3fc into quarkusio:master Jul 14, 2020
@sberyozkin
Copy link
Member Author

@gastaldi Thanks, I'm keeping my fingers crossed it all will be good :-), was OK in the local build

@sberyozkin sberyozkin deleted the oidc_roles_docs2 branch September 16, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants