Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quarkus-bom-deployment deprecated in 1.6.0.Final #10714

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Remove quarkus-bom-deployment deprecated in 1.6.0.Final #10714

merged 1 commit into from
Jul 17, 2020

Conversation

aloubyansky
Copy link
Member

Removed deprecated quarkus-bom-deployment BOM.

@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Jul 14, 2020
gastaldi
gastaldi reviewed Jul 14, 2020
View reviewed changes
extensions/pom.xml Outdated Show resolved Hide resolved
@gastaldi gastaldi added this to the 1.7.0 - master milestone Jul 14, 2020
gastaldi
gastaldi approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gsmet
gsmet requested changes Jul 15, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the Platform PR to be ready before merging this one: https://github.com/quarkusio/quarkus-platform/blob/master/bom/deployment/pom.xml#L29 .

Thanks!

@aloubyansky aloubyansky force-pushed the delete-quarkus-bom-deployment branch from 4d25cc6 to 2670138 Compare July 16, 2020 11:10
@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jul 16, 2020
@aloubyansky
Copy link
Member Author

The PR removing quarkus-bom-deployment from the platform is quarkusio/quarkus-platform#96

@aloubyansky aloubyansky force-pushed the delete-quarkus-bom-deployment branch 2 times, most recently from 311b497 to e8ce79c Compare July 16, 2020 14:10
@aloubyansky
Copy link
Member Author

@gsmet could you please review this one again when you get a chance? I moved the BOM from bom/runtime to bom/application. And now I have to rebase it a few times a day to avoid conflicts.

@aloubyansky aloubyansky force-pushed the delete-quarkus-bom-deployment branch from e8ce79c to 6918d3e Compare July 16, 2020 15:24
@gsmet
Copy link
Member

gsmet commented Jul 16, 2020

To be honest, I’m a bit worried about doing that in the summer.

What exactly will happen if we have extensions that don’t remove it? Will it fail big time or not?

@aloubyansky
Copy link
Member Author

They won't build with 1.7.0.Final. To fix that the import of quarkus-bom-deployment will have to be removed.

@aloubyansky aloubyansky force-pushed the delete-quarkus-bom-deployment branch from 6918d3e to 6731e45 Compare July 16, 2020 21:10
@aloubyansky aloubyansky force-pushed the delete-quarkus-bom-deployment branch from 6731e45 to 2beea9a Compare July 17, 2020 13:24
@boring-cyborg boring-cyborg bot added the area/gradle Gradle label Jul 17, 2020
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 17, 2020
@gsmet gsmet merged commit 06905ef into quarkusio:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/maven triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@aloubyansky @gsmet @gastaldi