Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevMojoIT: Remove superfluous first mvn install to avoid race condition #10703

Merged
merged 1 commit into from
Jul 14, 2020
Merged

DevMojoIT: Remove superfluous first mvn install to avoid race condition #10703

merged 1 commit into from
Jul 14, 2020

Conversation

famod
Copy link
Member

@famod famod commented Jul 13, 2020

As already mentioned on zulip, I think the first mvn install call was a c&p mistake or something. But I might be wrong.

One can clearly see the two "racy" executions in integration-tests/maven/target/test-classes/projects/multimodule-resources-classpath/build-multimodule-resources-classpath.log:

[INFO] Scanning for projects...
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO] 
[INFO] multimodule-cp-resources                                           [pom]
[INFO] multimodule-cp-resources-rest                                      [jar]
[INFO] multimodule-cp-resources-html                                      [jar]
[INFO] multimodule-cp-resources-main                                      [jar]
[INFO] 
[INFO] ------------------< cp.acme:multimodule-cp-resources >------------------
[INFO] Building multimodule-cp-resources 1.0-SNAPSHOT                     [1/4]
[INFO] --------------------------------[ pom ]---------------------------------
[INFO] multimodule-cp-resources                                           [pom]
[INFO] multimodule-cp-resources-rest                                      [jar]
[INFO] multimodule-cp-resources-html                                      [jar]
[INFO] multimodule-cp-resources-main                                      [jar]
[INFO] 
[INFO] ------------------< cp.acme:multimodule-cp-resources >------------------
[INFO] Building multimodule-cp-resources 1.0-SNAPSHOT                     [1/4]
[INFO] --------------------------------[ pom ]---------------------------------

I added another assert before the existing return code assert as we might see more helpful output in case the test is still flaky.

@famod famod requested a review from geoand July 13, 2020 22:18
@geoand
Copy link
Contributor

geoand commented Jul 14, 2020

Wow, great catch!

@geoand geoand merged commit 5ffccca into quarkusio:master Jul 14, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants