-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AWS Secrets Manager #10663
Adding AWS Secrets Manager #10663
Conversation
Hi @cmaluend, thanks, I think it should be tied somehow with the credentials-spi as well, https://github.com/quarkusio/quarkus/tree/master/extensions/credentials. |
Just wonder if this PR can contribute to resolving #6896 as well ? Would be great if it were possible :-). |
My goal was to be able to use AWS Secrets Manager in a native image. But, I think this is a good use case. I will take a look at it. This is my first contribution, probably I will have some questions. |
@marcinczeczko could you have a look at that one? |
I'm on PTO till the end of July, so can look at this on Aug.
czw., 16 lip 2020, 11:15 użytkownik Guillaume Smet <notifications@github.com>
napisał:
… @marcinczeczko <https://github.com/marcinczeczko> could you have a look
at that one?
@vsevel <https://github.com/vsevel> you might be interested in this one
too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAF4G7LE6SV4AIWSNNM7DLR33AL5ANCNFSM4OX4IOVQ>
.
|
@cmaluend Thanks for the great contribution so far, and also considering to expose this engine as Hopefully it will be quite straightforward given that you already have the working extension, |
@sberyozkin Example:
|
@cmaluend but Agroal gets the passwords from CredentialsProvider. Perhaps |
I will take a look at your ideas in the next few days. |
there are different use cases to consider:
from what I see you are tackling use cases 1 and 2. for the second one the correct approach is to create a config source. but there are a few challenges at the moment such as #4848 (which should be improved with #9991 (comment)). If you do not develop a config source, then an alternative is to make your extension implement the hope this makes it clearer. |
I will work on the CredetialsProvider this weekend. |
Hi @cmaluend How are you, have you had a chance to look at the |
Closing this one. Please reopen if you have some updates. |
@cmaluend any news? Youre extension looks very interesting. I hope the pull request gets merged :-) I would use youre changes! :) |
AWS Secrets Manager Extension
Description
The goal of this extension is to make easy then integration with AWS Secrets Manager. The extension provides an annotation to inject the secret into a variable. Also, it is possible to inject the client and use it directly.
Tasks
AWS Secrets Manager Clients
Sync Client
Async Client
AWS Secrets Manager Annotation
Allows injecting a secret from AWS Secrets Manager directly to a variable. It supports plaintext and binary secrets.