Fix Spring Data JPA Query Methods for big hierarchy #10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/hibernate-orm
|
Thanks a lot for the PR! I didn't look at the implementation, but the tests are failing, so there is definitely something wrong :) In addition to having the existing tests passing, we would need a test case for this feature |
nebrass
changed the title
|
The current tests are passing, 👍 Now what we need to merge the PR is a test case showing that this PR fixes |
|
@geoand I added more modifications and the required tests 😀 |
nebrass
changed the title
|
Thanks. I'll check tomorrow |
geoand
reviewed
Jul 13, 2020
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Show resolved
Hide resolved
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Outdated
Show resolved
Hide resolved
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Outdated
Show resolved
Hide resolved
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Outdated
Show resolved
Hide resolved
|
Thanks @geoand ! |
geoand
reviewed
Jul 13, 2020
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Outdated
Show resolved
Hide resolved
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Outdated
Show resolved
Hide resolved
...ng-data-jpa/deployment/src/main/java/io/quarkus/spring/data/deployment/MethodNameParser.java
Outdated
Show resolved
Hide resolved
Thank you @geoand for your help and availability ! 🥳 I'm celebrating my first PR in Quarkus ! 🤩 |
|
🎈 🎉 |
geoand
added
the
triage/waiting-for-ci
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Spring Data JPA Query Methods for big hierarchy.
Fixes #10581