Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests to Config, to ensure backwards compatibility. #10615

Merged
merged 2 commits into from
Jul 15, 2020

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jul 9, 2020

This is the initial PR to fix #10570. It only requires an update to a release of SmallRye Config 1.8.2, but wanted to add the tests to make sure we don't break stuff.

Additional, I've added the same set of tests in a 1.5.0 branch, to make sure we keep the same behaviour: https://github.com/radcortez/quarkus/tree/config-1.5

One test is failing due to the missing update of SmallRye Config that will fix it.

@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/maven labels Jul 9, 2020
@radcortez radcortez removed area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/maven labels Jul 9, 2020
@radcortez radcortez changed the title Added tests to Config, to ensure backwards compatibility. [WIP] Added tests to Config, to ensure backwards compatibility. Jul 9, 2020
@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Jul 9, 2020
@radcortez radcortez force-pushed the config branch 2 times, most recently from f9c867b to e88cf58 Compare July 13, 2020 10:10
@radcortez radcortez changed the title [WIP] Added tests to Config, to ensure backwards compatibility. Added tests to Config, to ensure backwards compatibility. Jul 13, 2020
@geoand
Copy link
Contributor

geoand commented Jul 13, 2020

CI seems to be misbehaving, tests didn't even start 😕

@radcortez
Copy link
Member Author

Yes, GH seems to be unstable today. I guess we need to wait until is sorted and then restart.

@radcortez
Copy link
Member Author

@geoand seems to be better today :)

Are we still maintaining 1.5x branch somehow? I can push the test code there as well, so we can see it also passes. Or you can just check it out and run it locally :D

https://github.com/radcortez/quarkus/tree/config-1.5

The more comprehensive set of tests should pass both in 1.5 (before the switch to SR Config) and in 1.6 (after the switch). If you look into both classes, the tests are the same, just some slight differences in the tests initialization:

1.5 - https://github.com/radcortez/quarkus/blob/config-1.5/core/runtime/src/test/java/io/quarkus/runtime/configuration/ConfigProfileTestCase.java

1.6 - https://github.com/radcortez/quarkus/blob/config/core/runtime/src/test/java/io/quarkus/runtime/configuration/ConfigProfileTestCase.java

@geoand
Copy link
Contributor

geoand commented Jul 14, 2020

@radcortez nope, 1.5 is no longer maintained

@geoand
Copy link
Contributor

geoand commented Jul 14, 2020

So if everything works against 1.6 / master, we should merge

@radcortez
Copy link
Member Author

@radcortez nope, 1.5 is no longer maintained

Sure, this was just if we wanted to have an extra layer of security that we are not breaking more things :(

@gsmet gsmet merged commit 45c0b03 into quarkusio:master Jul 15, 2020
@gsmet
Copy link
Member

gsmet commented Jul 15, 2020

@geoand the idea was to backport that one to 1.6.1, right?

@geoand
Copy link
Contributor

geoand commented Jul 15, 2020

Yes, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/core area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devmode, Regression in 1.6.0: Cannot override property from profile via system property
3 participants