-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests to Config, to ensure backwards compatibility. #10615
Conversation
f9c867b
to
e88cf58
Compare
CI seems to be misbehaving, tests didn't even start 😕 |
Yes, GH seems to be unstable today. I guess we need to wait until is sorted and then restart. |
@geoand seems to be better today :) Are we still maintaining 1.5x branch somehow? I can push the test code there as well, so we can see it also passes. Or you can just check it out and run it locally :D https://github.com/radcortez/quarkus/tree/config-1.5 The more comprehensive set of tests should pass both in 1.5 (before the switch to SR Config) and in 1.6 (after the switch). If you look into both classes, the tests are the same, just some slight differences in the tests initialization: |
@radcortez nope, 1.5 is no longer maintained |
So if everything works against 1.6 / master, we should merge |
Sure, this was just if we wanted to have an extra layer of security that we are not breaking more things :( |
@geoand the idea was to backport that one to 1.6.1, right? |
Yes, exactly |
This is the initial PR to fix #10570. It only requires an update to a release of SmallRye Config 1.8.2, but wanted to add the tests to make sure we don't break stuff.
Additional, I've added the same set of tests in a 1.5.0 branch, to make sure we keep the same behaviour: https://github.com/radcortez/quarkus/tree/config-1.5
One test is failing due to the missing update of SmallRye Config that will fix it.