Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for http max initial line length #10610

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

pcasaes
Copy link
Contributor

@pcasaes pcasaes commented Jul 9, 2020

Netty lets us configure tha maximum length of the initial length of an HTTP request. By default it's 4096.

https://netty.io/4.0/api/io/netty/handler/codec/http/HttpRequestDecoder.html

@gastaldi gastaldi added this to the 1.7.0 - master milestone Jul 9, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 9, 2020
@pcasaes
Copy link
Contributor Author

pcasaes commented Jul 9, 2020

Thanks. I was going to wait for the tests to pass before shooting out an email to the mailing group.

@pcasaes pcasaes force-pushed the pc/http-max-initial-length branch 2 times, most recently from 86a2ab3 to 58032a0 Compare July 9, 2020 15:42
@pcasaes pcasaes force-pushed the pc/http-max-initial-length branch from 58032a0 to cef4b55 Compare July 9, 2020 15:47
Netty lets us configure tha maximum length of the initial length of an HTTP request. By default it's 4096.

https://netty.io/4.0/api/io/netty/handler/codec/http/HttpRequestDecoder.html
@pcasaes pcasaes force-pushed the pc/http-max-initial-length branch from cef4b55 to 5746c0f Compare July 9, 2020 16:30
@pcasaes
Copy link
Contributor Author

pcasaes commented Jul 9, 2020

@gastaldi all tests passed. Once merged I'll look into the default for quarkus.http.limits.max-chunk-size

@gastaldi gastaldi merged commit 0e0457c into quarkusio:master Jul 9, 2020
@gastaldi
Copy link
Contributor

gastaldi commented Jul 9, 2020

Fantastic work! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation area/vertx triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants