Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow QuarkusDevModeTest to be run from IntelliJ #10554

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Allow QuarkusDevModeTest to be run from IntelliJ #10554

merged 1 commit into from
Jul 8, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 8, 2020

@geoand geoand requested a review from aloubyansky July 8, 2020 08:17
@geoand
Copy link
Contributor Author

geoand commented Jul 8, 2020

cc @mariofusco

@geoand geoand force-pushed the quarkusdevmodetest-intellij branch 3 times, most recently from 53d20d9 to 13f437f Compare July 8, 2020 08:28
@geoand geoand added this to the 1.7.0 - master milestone Jul 8, 2020
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 8, 2020
@geoand geoand force-pushed the quarkusdevmodetest-intellij branch from 13f437f to e81b498 Compare July 8, 2020 13:48
@famod
Copy link
Member

famod commented Jul 8, 2020 •
edited
Loading

Ah, interesting. I also had/have an NPE with QuarkusDevModeTest but in Eclipse.

This fix is really IntelliJ-specific, no?

@geoand
Copy link
Contributor Author

geoand commented Jul 8, 2020 •
edited
Loading

Ah, interesting. I also had/have an NPE with QuarkusDevModeTest but in Eclipse.

This fix is really IntelliJ-specific, no?

Yup, I haven't touched Eclipse in almost 10 years so I have no idea what it does. But based on this PR it should be easy to come up with an Eclipse fix

@famod
Copy link
Member

famod commented Jul 8, 2020

Ok, will have a look once this is merged.

@geoand geoand merged commit 82cd936 into quarkusio:master Jul 8, 2020
@geoand geoand deleted the quarkusdevmodetest-intellij branch July 8, 2020 21:59
nakamura-to added a commit to domaframework/doma-quarkus that referenced this pull request Jul 11, 2020
@nakamura-to
Always run all tests because now QuarkusDevModeTest doesn't throw Nul…
0550594 
…lPointerException in IntelliJ

See also quarkusio/quarkus#10554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/testing triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @famod @aloubyansky