Update asciidoctor-maven-plugin to latest stable v2.0.0 #10503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
LGTM, thanks @abelsromero. Let's also get @gsmet approval on this too.
|
I tested locally and it works great. Good job! |
gastaldi
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though main Quarkus site is build in another repo, asciidoctor-maven-plugin plugin released stable version, no need to keep the RC (release notes).
Also updates to latests Asciidoctorj, reviewed config, made a build of the docs, and everything is fine.