Add ability to disable security on a per test basis #10487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/dependencies
geoand
reviewed
Jul 6, 2020
...-framework/security/src/main/java/io/quarkus/test/security/QuarkusSecurityTestExtension.java
Show resolved
Hide resolved
geoand
reviewed
Jul 6, 2020
geoand
reviewed
Jul 6, 2020
|
|
||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({ ElementType.TYPE, ElementType.METHOD }) | ||
| public @interface TestSecurity { |
There was a problem hiding this comment.
I am not sold on the name, but I don't have any better alternatives to offer :(
Also allows for a user to be configured to run the tests under.
stuartwdouglas
force-pushed
the
enable-test-security
branch
from
e9d1bf4 to
fa6cede
Compare
geoand
approved these changes
Jul 6, 2020
|
@sberyozkin, @loicmathieu I think you will be interested in this as well |
|
Just saw it, very useful indead ! |
Yeah, I'm going to add that in a subsequent PR |
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jul 6, 2020
Follows up on: quarkusio#10487 Resolves: quarkusio#10490
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jul 6, 2020
Follows up on: quarkusio#10487 Resolves: quarkusio#10490
geoand
added a commit
to geoand/quarkus
that referenced
this pull request
Jul 7, 2020
Follows up on: quarkusio#10487 Resolves: quarkusio#10490
|
@geoand @stuartwdouglas, looks good thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows for a user to be configured to run the tests
under.