Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch liquibase dependency to 3.10.1 version #10482

Merged
merged 1 commit into from
Jul 5, 2020
Merged

Switch liquibase dependency to 3.10.1 version #10482

merged 1 commit into from
Jul 5, 2020

Conversation

andrejpetras
Copy link
Contributor

Issue: failed to find pre-indexed service interface liquibase.command.LiquibaseCommand, falling back to slow classpath scanning
Fix: Search for the implementation classes of the interface liquibase.command.LiquibaseCommand in the index

Issue: NPE
Fix: On Windows + jdk11 the class liquibase.pro.packaged.kp is not in the index (Could be index issue)
Fix: Add the implementation for license service liquibase.license.LicenseService interface manually.

// add license service manually. Index file for windows/jdk11 does not contain
// implementation 'liquibase.pro.packaged.kp' class for interface 'liquibase.license.LicenseService'
services.put(liquibase.license.LicenseService.class.getName(),
         Collections.singletonList("liquibase.pro.packaged.kp"));

Issue: XSD for native image
Fix: Currently we need to manually add the xsd for the native image for each version of the Liquibase.

"www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.7.xsd",
"www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.8.xsd",
"www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.9.xsd",
"www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.10.xsd",
"www.liquibase.org/xml/ns/dbchangelog/dbchangelog-ext.xsd",
"www.liquibase.org/xml/ns/pro/liquibase-pro-3.8.xsd",
"www.liquibase.org/xml/ns/pro/liquibase-pro-3.9.xsd",
"www.liquibase.org/xml/ns/pro/liquibase-pro-3.10.xsd",
"liquibase.build.properties"));

For this I created an issue #7033

@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Jul 5, 2020
@machi1990 machi1990 requested review from gsmet and Sanne July 5, 2020 12:21
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @andrejpetras, LGTM.

@Sanne Sanne merged commit c035570 into quarkusio:master Jul 5, 2020
@Sanne
Copy link
Member

Sanne commented Jul 5, 2020

Many thanks @andrejpetras !

@Sanne Sanne added this to the 1.7.0 - master milestone Jul 5, 2020
@Sanne Sanne added area/liquibase area/persistence OBSOLETE, DO NOT USE labels Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/liquibase area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants