Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid very unlikely NPE #10450

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Avoid very unlikely NPE #10450

merged 1 commit into from
Jul 3, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 3, 2020 •
edited
Loading

I was able to reproduce the NPE initially
when adding the test for #10421.
The way I got around it in that test was to
make sure the compile phase was invoked

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jul 3, 2020
@geoand
Avoid very unlikely NPE
5fea82b 
I was able to reproduce the NPE initially
when adding the test for
quarkusio#10421.
The way I got around it in that test was to
make sure the compile phase was invoked
@gsmet gsmet requested a review from aloubyansky July 3, 2020 08:57
@geoand geoand merged commit 1351db3 into quarkusio:master Jul 3, 2020
@geoand geoand deleted the dev-mojo-npe branch July 3, 2020 12:50
@aloubyansky aloubyansky mentioned this pull request Jul 9, 2020
Closed
@gsmet gsmet added this to the 1.6.1.Final milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
1.6.1.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @aloubyansky @gsmet