Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow openshift to work with docker and jib container images #10434

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Allow openshift to work with docker and jib container images #10434

merged 3 commits into from
Jul 15, 2020

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Jul 2, 2020

Resolves: #9663

@iocanel iocanel requested a review from geoand July 2, 2020 18:11
geoand
geoand reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't there also some checks in the Kubernetes processor that need to be updated?
Or do those just check for the capabilities that you know only enable conditionally?

...age/deployment/src/main/java/io/quarkus/container/image/deployment/ContainerImageConfig.java Show resolved Hide resolved
@iocanel
Copy link
Contributor Author

iocanel commented Jul 2, 2020

Aren't there also some checks in the Kubernetes processor that need to be updated?
Or do those just check for the capabilities that you know only enable conditionally?

I don't think that anything else needs updating. But I might miss something.

@geoand
Copy link
Contributor

geoand commented Jul 2, 2020

I'll need to take another look tomorrow

geoand
geoand approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@iocanel iocanel force-pushed the issue-9663-openshift-deployments branch from a03f3c9 to 1964390 Compare July 3, 2020 08:27
@iocanel iocanel force-pushed the issue-9663-openshift-deployments branch from a08d820 to 08fecc9 Compare July 3, 2020 08:30
@geoand
Copy link
Contributor

geoand commented Jul 3, 2020

Seems like you need to reformat the code

@gsmet gsmet changed the title Allow openshfit to work with docker and jib container images Allow openshift to work with docker and jib container images Jul 4, 2020
@gsmet gsmet force-pushed the issue-9663-openshift-deployments branch from 08fecc9 to b092dde Compare July 4, 2020 11:49
@gsmet
Copy link
Member

gsmet commented Jul 4, 2020

Pushed a rebase and fixed the formatting issue.

@geoand
Copy link
Contributor

geoand commented Jul 4, 2020 via email

@geoand
Copy link
Contributor

geoand commented Jul 4, 2020

JVM tests are failing so I guess there is some problem with the PR

@geoand
Copy link
Contributor

geoand commented Jul 8, 2020

@iocanel do you plan to fix this?

@iocanel iocanel force-pushed the issue-9663-openshift-deployments branch from b092dde to 1bc1de9 Compare July 13, 2020 15:52
@iocanel iocanel force-pushed the issue-9663-openshift-deployments branch from 1bc1de9 to 9254fc1 Compare July 14, 2020 07:45
This was linked to issues Jul 14, 2020
OpenShift deployment with kubernetes & container-image-docker extension does not work #10055
Closed
Fabric8 Kubernetes Client system properties and environment variables should be ignored. #10697
Closed
@iocanel iocanel removed a link to an issue Jul 14, 2020
Fabric8 Kubernetes Client system properties and environment variables should be ignored. #10697
Closed
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 14, 2020
@geoand geoand added this to the 1.7.0 - master milestone Jul 14, 2020
@geoand geoand merged commit 430ef0c into quarkusio:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
3 participants
@iocanel @geoand @gsmet