Hibernate Reactive services initiator fix #10382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tialization SQL script statements
…nerated (ImpliedBlockingPersistenceUnitTypeBuildItem)
…enceUnitDefinition
…eant for bytecode serialization
…e it for Reactive PUs
|
@ebullient : eb365c1 is meant for you. Is that what you had in mind? |
Sanne
commented
Jun 30, 2020
| @@ -36,9 +36,6 @@ public LightPersistenceXmlDescriptor(final PersistenceUnitDescriptor toClone) { | |||
| } | |||
|
|
|||
| private static void verifyIgnoredFields(final PersistenceUnitDescriptor toClone) { | |||
| if (toClone.getNonJtaDataSource() != null) { | |||
| throw new UnsupportedOperationException("Value found for #getNonJtaDataSource : not supported yet"); | |||
| } | |||
There was a problem hiding this comment.
the same check is repeated below
|
Assigned to @gsmet as it's rather urgent, but maybe @FroMage or @emmanuelbernard have time? |
gsmet
approved these changes
Jul 1, 2020
Yes! Thanks =) |
FroMage
approved these changes
Jul 1, 2020
.../runtime/src/main/java/io/quarkus/hibernate/orm/runtime/boot/RecordableBootstrapFactory.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10187