-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forkMode is deprecated since Surefire 2.14 #10375
Conversation
See "Migrating the Deprecated forkMode Parameter to forkCount and reuseForks" in https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html
LGTM, but let's ask @Tibor17 to be certain |
Raises the question why just these two modules are not reusing forks. |
@gastaldi Feel free to ping us if there is another bug. |
btw, the |
Thanks for the info @Tibor17 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change makes sense but indeed it would be nice to know why we want no forking in this case
@geoand Those two modules are forking but they do it for each test class (the fork of the previous test class is not reused). |
Ah, I didn't read the configuration correctly (on a phone). I have 2 guesses:
|
See "Migrating the Deprecated forkMode Parameter to forkCount and reuseForks" in https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html