Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forkMode is deprecated since Surefire 2.14 #10375

Merged
merged 1 commit into from
Jun 30, 2020
Merged

forkMode is deprecated since Surefire 2.14 #10375

merged 1 commit into from
Jun 30, 2020

Conversation

gastaldi
Copy link
Contributor

See "Migrating the Deprecated forkMode Parameter to forkCount and reuseForks" in https://maven.apache.org/surefire/maven-surefire-plugin/examples/fork-options-and-parallel-execution.html

@gastaldi gastaldi requested review from geoand and gsmet June 30, 2020 14:16
@geoand
Copy link
Contributor

geoand commented Jun 30, 2020

LGTM, but let's ask @Tibor17 to be certain

@famod
Copy link
Member

famod commented Jun 30, 2020

Raises the question why just these two modules are not reusing forks.

@gastaldi gastaldi added this to the 1.7.0 - master milestone Jun 30, 2020
@Tibor17
Copy link
Contributor

Tibor17 commented Jun 30, 2020

@gastaldi
@geoand
@famod
Hey guys, the forkMode will be removed. It is one config parameter which has two meaning (reusability of JVMs and the number of threads executing parallel CLIs). We in Maven decided to split forkMode in two, means forkCount and reuseForks. You should not have a problem to use both instead of forkMode.

Feel free to ping us if there is another bug.

@Tibor17
Copy link
Contributor

Tibor17 commented Jun 30, 2020

btw, the forkMode and forkCount + reuseForks appeared in the versions 2.x and forkMode was deprecated in 2.x several years ago. This is old story already.

@geoand
Copy link
Contributor

geoand commented Jun 30, 2020

Thanks for the info @Tibor17 !

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense but indeed it would be nice to know why we want no forking in this case

@gastaldi gastaldi merged commit 8e091b1 into quarkusio:master Jun 30, 2020
@gastaldi gastaldi deleted the forkmode branch June 30, 2020 19:21
@famod
Copy link
Member

famod commented Jun 30, 2020

@geoand Those two modules are forking but they do it for each test class (the fork of the previous test class is not reused).
Default is one fork per module that processes all test classes subsequently.

@geoand
Copy link
Contributor

geoand commented Jun 30, 2020

Ah, I didn't read the configuration correctly (on a phone).

I have 2 guesses:

  1. they do so because it more closely resembles what a "function" does
  2. there might be classloader issues when reusing these tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants