Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the use of QuarkusTestResourceLifecycleManager with @TestProfile #10368

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Allow the use of QuarkusTestResourceLifecycleManager with @TestProfile #10368

merged 1 commit into from
Jul 2, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 30, 2020

No description provided.

@geoand
Copy link
Contributor Author

geoand commented Jun 30, 2020

@stuartwdouglas let me know what you think. I am personally not real fond of the clunky signature of testResources so if you have any ideas, I'll love to hear them

@geoand geoand force-pushed the testresources-on-testprofile branch from b0d7c99 to ed81303 Compare July 1, 2020 04:47
@geoand geoand mentioned this pull request Jul 1, 2020
Closed
@stuartwdouglas
Copy link
Member

Maybe a custom type (TestResourceInstance?) that encapsulates the name and the parameters? The current signature does not allow for two resources of the same type with different params (e.g. two databases on different ports).

@geoand
Copy link
Contributor Author

geoand commented Jul 2, 2020

Good point

@geoand geoand force-pushed the testresources-on-testprofile branch from ed81303 to 34200ce Compare July 2, 2020 08:27
@geoand
Copy link
Contributor Author

geoand commented Jul 2, 2020

PR updated

@geoand geoand marked this pull request as ready for review July 2, 2020 08:41
@geoand geoand added this to the 1.7.0 - master milestone Jul 2, 2020
@geoand geoand requested a review from stuartwdouglas July 2, 2020 15:17
@stuartwdouglas stuartwdouglas merged commit b5d9cab into quarkusio:master Jul 2, 2020
@geoand geoand deleted the testresources-on-testprofile branch July 3, 2020 06:48
@famod famod mentioned this pull request Jul 21, 2020
Open
@famod famod mentioned this pull request Sep 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi left review comments

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @stuartwdouglas @gastaldi