Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Flyway transformer by providing tighter integration #10360

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Remove Flyway transformer by providing tighter integration #10360

merged 1 commit into from
Jun 30, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 30, 2020

Follow up of #10355

@geoand geoand requested review from gastaldi and gsmet June 30, 2020 06:53
gsmet
gsmet previously requested changes Jun 30, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor comments.

Nice to see some ASM gone :).

extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java Outdated Show resolved Hide resolved
extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/QuarkusResourceProvider.java Outdated Show resolved Hide resolved
extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/QuarkusClassProvider.java Outdated Show resolved Hide resolved
extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/QuarkusResourceProvider.java Outdated Show resolved Hide resolved
@geoand geoand force-pushed the flyway-remove-uneeded branch from d930759 to 5d03ba7 Compare June 30, 2020 08:56
@geoand geoand requested a review from gsmet June 30, 2020 08:57
gastaldi
gastaldi approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

@geoand
Copy link
Contributor Author

geoand commented Jun 30, 2020

Thanks!

@gastaldi gastaldi dismissed gsmet’s stale review June 30, 2020 11:59

Changes addressed

@gastaldi gastaldi merged commit 06f6f93 into quarkusio:master Jun 30, 2020
@gastaldi gastaldi deleted the flyway-remove-uneeded branch June 30, 2020 11:59
@gsmet gsmet mentioned this pull request Jul 1, 2020
Merged
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @gastaldi @gsmet