Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB2 JDBC extension #10349

Merged
merged 5 commits into from
Jul 1, 2020
Merged

DB2 JDBC extension #10349

merged 5 commits into from
Jul 1, 2020

Conversation

aguibert
Copy link
Member

@aguibert aguibert commented Jun 29, 2020 •
edited
Loading

Closes #6293

@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure labels Jun 29, 2020
@aguibert aguibert self-assigned this Jun 29, 2020
@aguibert aguibert added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Jun 29, 2020
gsmet
gsmet reviewed Jun 29, 2020
View reviewed changes
bom/runtime/pom.xml Outdated Show resolved Hide resolved
@aguibert aguibert mentioned this pull request Jun 29, 2020
Closed
gsmet
gsmet approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me apart from my minor comment about the timeout. I'll let you fix this.

I let you promote it once we have the GA of the driver.

.github/workflows/ci-actions.yml Show resolved Hide resolved
@aguibert aguibert marked this pull request as ready for review July 1, 2020 15:14
@aguibert aguibert added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 1, 2020
@aguibert aguibert changed the title WIP: DB2 JDBC extension DB2 JDBC extension Jul 1, 2020
@aguibert
Copy link
Member Author

aguibert commented Jul 1, 2020

Looks like CI completed fully green, and I confirmed that the new DB2 tests are now running:

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.934 s - in io.quarkus.it.jpa.db2.JPAFunctionalityInGraalITCase
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

I am going to amend the most recent commit to increase the job timeout from 55m --> 60m as @gsmet requested, but no need to wait for CI all over again just for that trivial change.

Looks ready to merge!

@gsmet gsmet added this to the 1.7.0 - master milestone Jul 1, 2020
@gsmet gsmet merged commit 38f4361 into quarkusio:master Jul 1, 2020
@aguibert aguibert removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees

@aguibert aguibert

Labels
area/core area/dependencies Pull requests that update a dependency file area/documentation area/hibernate-orm Hibernate ORM area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/persistence OBSOLETE, DO NOT USE release/noteworthy-feature
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Offer DB2 JDBC extension
2 participants
@aguibert @gsmet