-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus annotations when smallrye metrics in enabled #10341
Conversation
@maxandersen I wasn't able to find any information for the Prometheus specific application annotations on Openshift. Who is the best person to ask for this? |
This looks like a new feature, I'm not sure it's a good backport candidate. |
OK, no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am wondering if in the future we also need to support the ServiceMonitor
custom resource which is an operator based alternative to those annotations!
@brancz Hey! @maxandersen mentioned that you are the right person to help us figure out what the proper way of monitoring applications (via Prometheus) that are running on Openshift is. To give you some context, in Quarkus we generate the Kubernetes / Openshift manifests based on the various capabilities the application has and we are wondering what Kubernetes manifests we should be generating in order to properly monitor a user application on Openshift. Thanks! |
Yes as @iocanel mentioned |
Thanks @brancz, I'll check it out |
thanks @brancz - just want to grok when the prometheus annotations are relevant and when they aren't - are you saying ServiceMonitor are the key and then prometheus annotations are irrelevant or should both be applied ? |
Looks like we should start supporting the Prometheus CRD. @iocanel does dekorate have the ability to generate that? |
Fixes: #10301