Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus annotations when smallrye metrics in enabled #10341

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jun 29, 2020

Fixes: #10301

@geoand
Copy link
Contributor Author

geoand commented Jun 29, 2020

@maxandersen I wasn't able to find any information for the Prometheus specific application annotations on Openshift. Who is the best person to ask for this?

@gsmet
Copy link
Member

gsmet commented Jun 30, 2020

This looks like a new feature, I'm not sure it's a good backport candidate.

@geoand
Copy link
Contributor Author

geoand commented Jun 30, 2020

OK, no problem.

@geoand geoand added this to the 1.7.0 - master milestone Jun 30, 2020
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am wondering if in the future we also need to support the ServiceMonitor custom resource which is an operator based alternative to those annotations!

@gastaldi gastaldi merged commit 6b8ef4f into quarkusio:master Jun 30, 2020
@gastaldi gastaldi deleted the #10301 branch June 30, 2020 12:18
@geoand
Copy link
Contributor Author

geoand commented Jul 13, 2020

@brancz Hey! @maxandersen mentioned that you are the right person to help us figure out what the proper way of monitoring applications (via Prometheus) that are running on Openshift is.

To give you some context, in Quarkus we generate the Kubernetes / Openshift manifests based on the various capabilities the application has and we are wondering what Kubernetes manifests we should be generating in order to properly monitor a user application on Openshift.

Thanks!

@brancz
Copy link

brancz commented Jul 14, 2020

Yes as @iocanel mentioned ServiceMonitors are the mechanism to use in OpenShift (and the larger Kubernetes ecosystem for anyone using the prometheus-operator, which is a very popular project and many people use it). In OpenShift everything will work out of the box with the new "user workload monitoring" feature when you create a ServiceMonitor.

@geoand
Copy link
Contributor Author

geoand commented Jul 14, 2020

Thanks @brancz, I'll check it out

@maxandersen
Copy link
Member

thanks @brancz - just want to grok when the prometheus annotations are relevant and when they aren't - are you saying ServiceMonitor are the key and then prometheus annotations are irrelevant or should both be applied ?

@geoand
Copy link
Contributor Author

geoand commented Jul 16, 2020

Looks like we should start supporting the Prometheus CRD. @iocanel does dekorate have the ability to generate that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement : add Prometheus annotation when extension : metrics + kubernetes are used
6 participants