Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Elytron Security extensions config overridable at runtime #10334

Merged
merged 4 commits into from
Jun 30, 2020
Merged

Make Elytron Security extensions config overridable at runtime #10334

merged 4 commits into from
Jun 30, 2020

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 29, 2020 •
edited
Loading

Fixes #10259

Also allow anonymous bind for the LDAP extension.

@gsmet gsmet mentioned this pull request Jun 29, 2020
Closed
@gsmet gsmet changed the title Security config Make Elytron Security extensions config overridable at runtime Jun 29, 2020
@gsmet gsmet requested a review from sberyozkin June 29, 2020 11:43
@gsmet
Copy link
Member Author

gsmet commented Jun 29, 2020

I'm in favor of backporting that one as things are barely usable the way it is.

@sberyozkin
Copy link
Member

@gsmet Hi Guillaume, thanks, I'd like to suggest to have a boolean property added allowing the anonymous binds...I don't know much about practical LDAP but it feels like we'd better off by letting the users make the explicit decision about it

@sberyozkin sberyozkin self-requested a review June 29, 2020 22:16
sberyozkin
sberyozkin approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet LGTM. I've realized that quarkus-oidc have both client id and secret also optional :-)
Thanks @gsmet , @gastaldi

@gsmet gsmet merged commit ce2e424 into quarkusio:master Jun 30, 2020
@gsmet
Copy link
Member Author

gsmet commented Jun 30, 2020

Thanks @sberyozkin !

@gsmet gsmet added this to the 1.7.0 - master milestone Jun 30, 2020
@gsmet gsmet modified the milestones: 1.7.0 - master, 1.6.0.Final Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@gastaldi gastaldi gastaldi left review comments

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/security
Projects
None yet
Milestone
1.6.0.Final
Development

Successfully merging this pull request may close these issues.

LDAP Security - configuration needs to be modifiable at runtime
4 participants
@gsmet @sberyozkin @gastaldi @geoand