Enable forwarded for prefix header configuration #10266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Jun 29, 2020
There was a problem hiding this comment.
Thanks!
Considering this has serious security considerations, I will let @stuartwdouglas review it but I did a pass on the doc.
gsmet
approved these changes
Jul 3, 2020
|
@stuartwdouglas doc is good for me on this one. I'll let you validate the security aspect of it. |
|
Hi @stuartwdouglas Can you have a quick look please, it LGTM, we can merge if you are happy as well with it |
stuartwdouglas
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last part of #9622 that enable users to configure the header to be used to prefix the HTTP request's URI. It includes also documentation how to setup it.
Fixes: #9622