Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST client encoding test #10246

Merged
merged 1 commit into from
Oct 12, 2020
Merged

REST client encoding test #10246

merged 1 commit into from
Oct 12, 2020

Conversation

stuartwdouglas
Copy link
Member

@stuartwdouglas stuartwdouglas commented Jun 25, 2020 •
edited
Loading

Test for #10245

This needs to be fixed in RESTEasy, so the test can be merged: resteasy/resteasy#2456

@gastaldi gastaldi marked this pull request as ready for review October 9, 2020 17:42
@gastaldi
Copy link
Contributor

gastaldi commented Oct 9, 2020 •
edited
Loading

RESTEasy was updated and the test passed locally. Time to mark this PR as ready to review

@gastaldi gastaldi added this to the 1.10 - master milestone Oct 9, 2020
@gastaldi gastaldi added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Oct 9, 2020
@gsmet gsmet merged commit 8304773 into quarkusio:master Oct 12, 2020
@gsmet
Copy link
Member

gsmet commented Oct 12, 2020

Let's not backport the test, I don't think it's worth it.

@gsmet
Copy link
Member

gsmet commented Oct 12, 2020

Hum.

The test is not working on Windows unfortunately:

Error:  Failures: 
Error:    RestClientTestCase.testEmojis:51 1 expectation failed.
Response body doesn't match expectation.
Expected: is "????????"
  Actual: 😀😀😀😀😀😀😀😀

@gsmet
Copy link
Member

gsmet commented Oct 12, 2020

I somehow missed it when merging.

@gastaldi
Copy link
Contributor

It looks like the server part works fine but the test doesn't?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartwdouglas @gastaldi @gsmet