Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apicurio added to Avro test #10213

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Apicurio added to Avro test #10213

merged 1 commit into from
Jul 10, 2020

Conversation

phillip-kruger
Copy link
Member

In this PR we added Apicurio Avro Serializer and Deserializer to the Kafka connector.
Also updated to use the latest version of Apicurio registry.

This partially fix #9478 (Documentation still outstanding)

Signed-off-by: Phillip Kruger [email protected]

@phillip-kruger
Copy link
Member Author

@cescoffier native should build now. Let's see ....

gsmet
gsmet previously requested changes Jun 24, 2020
integration-tests/kafka/pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger phillip-kruger requested a review from gsmet June 25, 2020 11:18
@gsmet
Copy link
Member

gsmet commented Jun 30, 2020

Is it just me or we don't test native?

@gsmet
Copy link
Member

gsmet commented Jun 30, 2020

Also I don't see the value in backporting it tbh. It can wait for the next release given there wasn't any fix applied.

@phillip-kruger
Copy link
Member Author

Yea we don't test native because it does not work :)

@gsmet gsmet dismissed their stale review July 10, 2020 14:17

Comment addressed.

@gsmet
Copy link
Member

gsmet commented Jul 10, 2020

No opinion on this one, merged as @cescoffier approved it.

@gsmet gsmet merged commit f8b82a3 into quarkusio:master Jul 10, 2020
@phillip-kruger phillip-kruger deleted the smallrye-reactive-messaging-kafka-avro branch July 10, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Avro support to the Kafka connector
3 participants