Don't trigger a native-image warning about using -H:+IncludeAllTimeZo…

[Sanne]

…nes explicitly

This should have no impact, other than removing a deprecation warning from the native-image compilation logs.

[gastaldi]

The MySQL tests failed with the following exception (probably related to your change?)

2020-06-16T19:59:33.0996448Z Caused by: java.sql.SQLException: No timezone mapping entry for 'Etc/GMT'
2020-06-16T19:59:33.0996732Z 	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:129)
2020-06-16T19:59:33.0999565Z 	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:97)
2020-06-16T19:59:33.1005153Z 	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:89)
2020-06-16T19:59:33.1011159Z 	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:63)
2020-06-16T19:59:33.1011360Z 	at com.mysql.cj.jdbc.exceptions.SQLError.createSQLException(SQLError.java:73)
2020-06-16T19:59:33.1014115Z 	at com.mysql.cj.jdbc.exceptions.SQLExceptionsMapping.translateException(SQLExceptionsMapping.java:85)
2020-06-16T19:59:33.1014336Z 	at com.mysql.cj.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:836)
2020-06-16T19:59:33.1016878Z 	at com.mysql.cj.jdbc.ConnectionImpl.<init>(ConnectionImpl.java:456)
2020-06-16T19:59:33.1017074Z 	at com.mysql.cj.jdbc.ConnectionImpl.getInstance(ConnectionImpl.java:246)
2020-06-16T19:59:33.1017266Z 	at com.mysql.cj.jdbc.NonRegisteringDriver.connect(NonRegisteringDriver.java:197)
2020-06-16T19:59:33.1017471Z 	at io.agroal.pool.ConnectionFactory.createConnection(ConnectionFactory.java:200)
2020-06-16T19:59:33.1020705Z 	at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:419)
2020-06-16T19:59:33.1021069Z 	at io.agroal.pool.ConnectionPool$CreateConnectionTask.call(ConnectionPool.java:401)
2020-06-16T19:59:33.1021281Z 	at java.util.concurrent.FutureTask.run(FutureTask.java:264)
2020-06-16T19:59:33.1021487Z 	at io.agroal.pool.util.PriorityScheduledExecutor.beforeExecute(PriorityScheduledExecutor.java:65)
2020-06-16T19:59:33.1024676Z 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1126)
2020-06-16T19:59:33.1027585Z 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
2020-06-16T19:59:33.1027776Z 	at java.lang.Thread.run(Thread.java:834)
2020-06-16T19:59:33.1030289Z 	at com.oracle.svm.core.thread.JavaThreads.threadStartRoutine(JavaThreads.java:497)
2020-06-16T19:59:33.1030509Z 	at com.oracle.svm.core.posix.thread.PosixJavaThreads.pthreadStartRoutine(PosixJavaThreads.java:193)
2020-06-16T19:59:33.1034370Z Caused by: com.mysql.cj.exceptions.WrongArgumentException: No timezone mapping entry for 'Etc/GMT'
2020-06-16T19:59:33.1040068Z 	at java.lang.reflect.Constructor.newInstance(Constructor.java:490)
2020-06-16T19:59:33.1045047Z 	at com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:61)
2020-06-16T19:59:33.1048884Z 	at com.mysql.cj.exceptions.ExceptionFactory.createException(ExceptionFactory.java:85)
2020-06-16T19:59:33.1055595Z 	at com.mysql.cj.protocol.a.NativeProtocol.configureTimezone(NativeProtocol.java:2134)
2020-06-16T19:59:33.1060599Z 	at com.mysql.cj.protocol.a.NativeProtocol.initServerSession(NativeProtocol.java:2143)
2020-06-16T19:59:33.1065127Z 	at com.mysql.cj.jdbc.ConnectionImpl.initializePropsFromServer(ConnectionImpl.java:1310)
2020-06-16T19:59:33.1065987Z 	at com.mysql.cj.jdbc.ConnectionImpl.connectOneTryOnly(ConnectionImpl.java:967)
2020-06-16T19:59:33.1072022Z 	at com.mysql.cj.jdbc.ConnectionImpl.createNewIO(ConnectionImpl.java:826)
2020-06-16T19:59:33.1077772Z 	... 13 more
2020-06-16T19:59:33.1082421Z 

[Sanne]

ah, 19.3.1 .. of course, the flags are still necessary on older supported GraalVM versions.

I'll close, we can revisit later. Thanks @gastaldi !