Enable programmatic security in SmallRye GraphQL endpoints #10004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillip-kruger
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
Thanks @jmartisk ! I wanted to ask you if you know how to do this !
gsmet
reviewed
Jun 17, 2020
...ye-graphql/deployment/src/test/java/io/quarkus/smallrye/graphql/deployment/SecurityTest.java
Outdated
Show resolved
Hide resolved
gsmet
reviewed
Jun 17, 2020
| Instance<CurrentIdentityAssociation> association = Arc.container().select(CurrentIdentityAssociation.class); | ||
| if (association.isResolvable()) { | ||
| association.get().setIdentity(QuarkusHttpUser.getSecurityIdentity(ctx, null)); | ||
| } |
There was a problem hiding this comment.
@stuartwdouglas could you check that one? Looks like a good backport candidate.
stuartwdouglas
previously requested changes
Jun 17, 2020
...ntime/src/main/java/io/quarkus/smallrye/graphql/runtime/SmallRyeGraphQLExecutionHandler.java
Outdated
Show resolved
Hide resolved
jmartisk
force-pushed
the
master-issue-10001
branch
2 times, most recently
from
677ad4b to
a7192fe
Compare
jmartisk
force-pushed
the
master-issue-10001
branch
from
a7192fe to
1b5ff56
Compare
gsmet
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10001