Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when cluster is not available should build not fail when deploy requested ? #9129

Closed
maxandersen opened this issue May 6, 2020 · 2 comments · Fixed by #9143
Closed

when cluster is not available should build not fail when deploy requested ? #9129

maxandersen opened this issue May 6, 2020 · 2 comments · Fixed by #9143
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@maxandersen
Copy link
Member

Describe the bug
have cluster configured in kube but the cluster being down/not reachable:
run mvn clean package -Dquarkus.kubernetes.deploy=true

and you get output like this:

[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[ERROR] [io.quarkus.kubernetes.deployment.KubernetesDeploy] Although a Kubernetes deployment was requested, it will however not take place because there was an error during communication with the API Server: An error has occurred.
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[INFO] [org.jboss.threads] JBoss Threads version 3.1.1.Final
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[WARNING] Error reading service account token from: [/var/run/secrets/kubernetes.io/serviceaccount/token]. Ignoring.
[INFO] [io.quarkus.deployment.pkg.steps.JarResultBuildStep] Building thin jar: /Users/max/Dropbox/code/openshift-deployment/target/simple-1.0.0-SNAPSHOT-runner.jar
[INFO] Initializing dekorate session.
[INFO] Default s2i build generator....
[INFO] Generating manifests.
[INFO] Processing kubernetes configuration.
[INFO] Processing openshift configuration.
[INFO] Processing s2i configuration.
[INFO] Closing dekorate session.
[INFO] [io.quarkus.deployment.QuarkusAugmentor] Quarkus augmentation completed in 8761ms
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

Expected behavior
I would have expected a BUILD FAILURE here.

Actual behavior
build marked as success despite there are errors.

@maxandersen maxandersen added the kind/bug Something isn't working label May 6, 2020
@maxandersen
Copy link
Member Author

in addition at no point do we actually print out which server/cluster/api endpoint that is being pushed to - hard to debug.

@geoand
Copy link
Contributor

geoand commented May 7, 2020

Makes sense - I'll take care of it.

@geoand geoand self-assigned this May 7, 2020
geoand added a commit to geoand/quarkus that referenced this issue May 7, 2020
geoand added a commit to geoand/quarkus that referenced this issue May 7, 2020
geoand added a commit to geoand/quarkus that referenced this issue May 7, 2020
geoand added a commit that referenced this issue May 8, 2020
Fail the build when a k8s deployment was requested by API server can't be reached
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 18, 2020
@gsmet gsmet added this to the 1.5.0 milestone May 18, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants