Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes: remove useless and potentially confusing dekorate output #8798

Closed
metacosm opened this issue Apr 23, 2020 · 9 comments · Fixed by #9270
Closed

Kubernetes: remove useless and potentially confusing dekorate output #8798

metacosm opened this issue Apr 23, 2020 · 9 comments · Fixed by #9270
Assignees
Labels
Milestone

Comments

@metacosm
Copy link
Contributor

Description
When using the Kubernetes extension, one will see the following (or similar output) during build:

[INFO] Initializing dekorate session.
[INFO] Default s2i build generator....
[INFO] Registering s2i handler!
[INFO] Registering s2i handler!
[INFO] Generating manifests.
[INFO] Processing kubernetes configuration.
[INFO] Processing openshift configuration.
[INFO] Processing s2i configuration.
[INFO] Closing dekorate session.

This not only doesn't provide any useful information but is potentially confusing, in particular when neither openshift nor s2i extensions are enabled.

@metacosm metacosm added the kind/enhancement New feature or request label Apr 23, 2020
@gsmet
Copy link
Member

gsmet commented Apr 23, 2020

I agree this should be debug.

@geoand WDYT?

@geoand
Copy link
Contributor

geoand commented Apr 23, 2020

Yeah, this output make no sense most of the time and should be debug logging

@geoand
Copy link
Contributor

geoand commented Apr 24, 2020

@metacosm do you plan on working on this?

It looks like it might need some changed in dekorate as well, since these messages come from an internal dekorate implementation (which I assume was done to get past problems with logging and annotation processors).

@metacosm
Copy link
Contributor Author

Planning on working on #8792 first, though I might work on this at the same time.

@geoand
Copy link
Contributor

geoand commented Apr 24, 2020

Cool

@geoand
Copy link
Contributor

geoand commented Apr 24, 2020

I'll do this one real quick then :)

geoand added a commit to dekorateio/dekorate that referenced this issue Apr 24, 2020
geoand added a commit to dekorateio/dekorate that referenced this issue Apr 24, 2020
geoand added a commit to dekorateio/dekorate that referenced this issue Apr 27, 2020
@geoand geoand self-assigned this Apr 29, 2020
@geoand
Copy link
Contributor

geoand commented Apr 29, 2020

This also requires: dekorateio/dekorate#488

I should have fixed that in the first place... Oh well

@gsmet
Copy link
Member

gsmet commented May 4, 2020

I removed the backport tag and marked it for 1.5.0 so that we don't forget about it.

@geoand
Copy link
Contributor

geoand commented May 4, 2020

Good idea. This needs a new dekorate release to be properly fixed

geoand added a commit to geoand/quarkus that referenced this issue May 13, 2020
geoand added a commit to geoand/quarkus that referenced this issue May 13, 2020
geoand added a commit that referenced this issue May 13, 2020
Improve Kubernetes extension logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants