Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New "Launching JVM" log line appearing in quarkus:dev #6183

Closed
gsmet opened this issue Dec 15, 2019 · 5 comments · Fixed by #6186
Closed

New "Launching JVM" log line appearing in quarkus:dev #6183

gsmet opened this issue Dec 15, 2019 · 5 comments · Fixed by #6186
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@gsmet
Copy link
Member

gsmet commented Dec 15, 2019

Just launched a project with quarkus:dev and got that one:

[INFO] Launching JVM with command line: /data/opt/jdk1.8.0_221/jre/bin/java -XX:TieredStopAtLevel=1 -Xverify:none -Xdebug -Xrunjdwp:transport=dt_socket,address=5005,server=y,suspend=n -Djava.util.logging.manager=org.jboss.logmanager.LogManager -jar /tmp/jpa-example/target/jpa-example-dev.jar

I don't think it's something we want at the info level.

@gastaldi is this the one you tweaked the other day? Do you know when it was introduced and why?

@gsmet gsmet added kind/bug Something isn't working backport? labels Dec 15, 2019
@gsmet
Copy link
Member Author

gsmet commented Dec 15, 2019

OK, so it was the one you tweaked and it was originally changed here: #5366 .

@jaikiran @stuartwdouglas I can't say I agree with this. We tried hard to not be verbose and this definitely seem too verbose and technical to me.

@gastaldi
Copy link
Contributor

I made the Gradle version display the same output as in Maven. The PR you linked changed to INFO but I must say I am not a big fan of it.

IMHO it should be a debug statement using the plugin 's logger

@gsmet
Copy link
Member Author

gsmet commented Dec 15, 2019

Yeah, I agree. If some of the info is useful, we need to present it another way. In the meantime, I would prefer it to go back to debug.

@gastaldi would you be up for preparing a patch?

@gastaldi
Copy link
Contributor

Sure, assign this issue to me and I'll submit a PR soon

@jaikiran
Copy link
Member

@jaikiran @stuartwdouglas I can't say I agree with this. We tried hard to not be verbose and this definitely seem too verbose and technical to me.

Hello @gsmet, it's fine with me if we want to go back to using DEBUG here.

@gsmet gsmet added this to the 1.1.0 milestone Dec 16, 2019
@gsmet gsmet removed the backport? label Dec 16, 2019
gsmet pushed a commit that referenced this issue Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants