Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in PanacheJpaRepositoryEnhancer #5274

Closed
nelsongraca opened this issue Nov 7, 2019 · 1 comment
Closed

Bug in PanacheJpaRepositoryEnhancer #5274

nelsongraca opened this issue Nov 7, 2019 · 1 comment
Labels
kind/bug Something isn't working
Milestone
1.0.0.CR2

Comments

@nelsongraca
Copy link

Describe the bug
When implementing PanacheRepositoryBase on an abstract class so I can extend from it on my repositories when running the jar I get the following error:
Caused by: java.lang.ClassFormatError: Duplicate method name "findById" with signature "(Ljava.lang.Object;)Ljava.lang.Object;" in class file com/flowkode/panache/TestEntityRepository

To Reproduce
Steps to reproduce the behavior:

  1. clone this repo: https://github.com/nelsongraca/quarkus-panache-bug
  2. ./mvnw clean package && java -jar target/panache-bug-1.0.0-SNAPSHOT-runner.jar
  3. on TestEntityRepository if you comment line 8 and uncomment line 9, everything runs well.
@nelsongraca nelsongraca added the kind/bug Something isn't working label Nov 7, 2019
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Panache: do not create findById bridge for abstract entity repositories
23c638b 
If the entity type is not fixed in the hierarchy yet, don't generate the bridge

Fix quarkusio#5274
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Test for quarkusio#5274: duplicate findById for abstract repositories
bec228a
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Fix quarkusio#5274 for Mongo too
6cbdeeb
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Test for quarkusio#5274 for Mongo
eef3aaf
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Panache: do not create findById bridge for abstract entity repositories
d2a645d 
If the entity type is not fixed in the hierarchy yet, don't generate the bridge

Fix quarkusio#5274
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Test for quarkusio#5274: duplicate findById for abstract repositories
7604ce0
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Fix quarkusio#5274 for Mongo too
34df40e
FroMage added a commit to FroMage/quarkus that referenced this issue Nov 7, 2019
@FroMage
Test for quarkusio#5274 for Mongo
df79555
@nelsongraca
Copy link
Author

Being fixed in #5276

gsmet pushed a commit that referenced this issue Nov 14, 2019
@FroMage @gsmet
Fix for 5274 (#5276)
7ac2c68 
* Panache: do not create findById bridge for abstract entity repositories

If the entity type is not fixed in the hierarchy yet, don't generate the bridge

Fix #5274

* Test for #5274: duplicate findById for abstract repositories

* Fix #5274 for Mongo too

* Test for #5274 for Mongo
@gsmet gsmet added this to the 1.0.0.Final milestone Nov 15, 2019
ia3andy pushed a commit to dmlloyd/quarkus that referenced this issue Nov 19, 2019
@FroMage @ia3andy
Fix for 5274 (quarkusio#5276)
7372929 
* Panache: do not create findById bridge for abstract entity repositories

If the entity type is not fixed in the hierarchy yet, don't generate the bridge

Fix quarkusio#5274

* Test for quarkusio#5274: duplicate findById for abstract repositories

* Fix quarkusio#5274 for Mongo too

* Test for quarkusio#5274 for Mongo
@loicmathieu loicmathieu mentioned this issue Dec 3, 2019
Closed
mmusgrov pushed a commit to mmusgrov/quarkus that referenced this issue Dec 13, 2019
@FroMage @mmusgrov
Fix for 5274 (quarkusio#5276)
fba6c0d 
* Panache: do not create findById bridge for abstract entity repositories

If the entity type is not fixed in the hierarchy yet, don't generate the bridge

Fix quarkusio#5274

* Test for quarkusio#5274: duplicate findById for abstract repositories

* Fix quarkusio#5274 for Mongo too

* Test for quarkusio#5274 for Mongo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
1.0.0.CR2
Development

No branches or pull requests
2 participants
@gsmet @nelsongraca