-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatch in ConfigProviderResolver instances after boot #4512
Comments
Hey @dmlloyd, is it really required by design that we use How about we, for example, enhance the |
CC @kenfinnigan this is the issue with the MP Metrics TCK I mentioned on yesterday's call |
This is a known issue. There is a fix pending in SmallRye Config which will allow us to customize the config provider resolver to the degree that we need to do so. |
@dmlloyd is there a SmallRye Config issue already that this relates to? |
It was part of smallrye/smallrye-config#168. |
So we just need a release of it, and update Quarkus? |
Basically it's pending release and corresponding Quarkus fixes, but I have been waiting to ask for a release until all the Quarkus work is done. |
I know Sonatype is a pain at the moment, but do you want me to try releasing Config? Or there's more work still? |
It won't fix the problem until the Quarkus config setup is modified. We could do a separate pull for that but I'm already in the midst of another mega config fix which will cover that so I was just going to do it all at once, as is my wont. |
Ok, but are there more changes to SRye Config needed? Or you think we're done and a release would help you finalize the mega fix? |
There might or might not be more changes needed: I won't be sure until I finish the Quarkus change, TBH. |
Fair enough, keep us posted |
How's the big config PR going @dmlloyd? |
Working, sort of. Just fixing some glitches. Then I have to add a bunch more tests. |
Ok, if there's anything I can do to help, just let me know |
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes quarkusio#2292 (partially), Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groudwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
Fixes quarkusio#4123, Fixes quarkusio#4119, Fixes quarkusio#4172, Fixes (part of) quarkusio#2292 Fixes quarkusio#734, Fixes quarkusio#4512, Fixes quarkusio#3498, Fixes quarkusio#3937 Fixes quarkusio#2816, Fixes quarkusio#4077, Fixes quarkusio#3516, Fixes quarkusio#2760 Fixes quarkusio#1989, Fixes quarkusio#3030, Fixes quarkusio#3637, Fixes quarkusio#1887 Groundwork for quarkusio#2489, Fixes quarkusio#5116, Fixes quarkusio#5192, Fixes quarkusio#3888 Fixes quarkusio#3089, Fixes quarkusio#390, Fixes quarkusio#891, Fixes quarkusio#5484 Fixes quarkusio#5454
During runtime init we explicitly build an instance of
SimpleConfigurationProviderResolver
and pass it toConfigProviderResolver.setInstance()
[1][2], but there is also the static fieldConfigProvider.INSTANCE
[3] that initializes by callingConfigProviderResolver.instance()
BEFORE we doConfigProviderResolver.setInstance()
, which leads to instantiation of aSmallRyeConfigProviderResolver
(!!!). As a consequence, the fieldsConfigProviderResolver.instance
andConfigProvider.INSTANCE
, which should contain the same instance ofSimpleConfigurationProviderResolver
, actually contain not only two different instances, but they are of two different classes.Normally these two resolvers resolve to equivalent config instances, but this issue manifests when an application registers a custom
Config
usingConfigProviderResolver.instance().registerConfig()
, becase after this, two differentConfig
instances will be returned fromConfigProviderResolver.instance().getConfig()
(this will contain the new dynamically created one) andConfigProvider.getConfig()
(this will contain the original one created during boot).I know we don't quite support registering a custom
Config
at runtime, but the Metrics TCK is doing this in one test, we should at least get this test working.IIUC we don't want to use
SmallRyeConfigProviderResolver
in Quarkus at all (and instead use theSimpleConfigurationProviderResolver
) so we need to get rid of instantiating the former.[1] https://github.com/quarkusio/quarkus/blob/0.24.0/core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java#L515
[2] https://github.com/eclipse/microprofile-config/blob/1.3/api/src/main/java/org/eclipse/microprofile/config/ConfigProvider.java#L74
[3] https://github.com/eclipse/microprofile-config/blob/1.3/api/src/main/java/org/eclipse/microprofile/config/spi/ConfigProviderResolver.java#L44
The text was updated successfully, but these errors were encountered: