Spring Cloud Configuration ordinal customization

[thibaultmeyer]

Description

Currently, the ordinal of the Spring Cloud Configuration values start at 450 (SpringCloudConfigClientConfigSourceFactory#76). This value is a bit high, according to the Quarkus documentation, System Properties have a ordinal of 400. With a ordinal of 450, Spring Cloud Configuration values cannot be overridden by existing configuration sources.

Implementation ideas

Like the extension quarkus-vault, it could be a good idea to let the developper to choose ordinal of the Spring Cloud Configuration sources.

Currently

int ordinal = 450;
// Profiles are looked from the highest ordinal to lowest, so we reverse the collection to build the source list
Collections.reverse(responses);
for (Response response : responses) {
    /* ... */

Changes

int ordinal = config.ordinal();
// Profiles are looked from the highest ordinal to lowest, so we reverse the collection to build the source list
Collections.reverse(responses);
for (Response response : responses) {
    /* ... */

config.ordinal() will be defined in SpringCloudConfigClientConfig with default value of 450.

[quarkus-bot]

/cc @aureamunoz (spring), @geoand (spring), @radcortez (config)

[geoand]

Makes sense!

Would you like to contribute that?

[thibaultmeyer]

hi @geoand

no problem, I'm preparing a pull request.

[geoand]

🙏🏽

[thibaultmeyer]

@geoand

I've just opened a PR to add ordinal customisation

[gsmet]

@thibaultmeyer do you have the default ordinal for Quarkus Vault in mind? Probably a good idea to make them consistent.

[quarkus-bot]

@gsmet triage/backport* labels may not be added to an issue. Please add them to the corresponding pull request.

_{This message is automatically generated by a bot.}

[thibaultmeyer]

hi @gsmet

quarkus-vault ordinal is 270 (VaultRuntimeConfig.java#L32).