ArrayIndexOutOfBoundsException occurred when i was serializing data from redis with quarkus redis extension

[Awen92]

Describe the bug

As the title, when i was serializing data from redis, i got an excetion, i found that there were sth wrong with Marshaller while JDK compiles the code.

Here is the sourece code of Marshaller

final <F, V> Map<F, V> decodeAsOrderedMap(Response response, Type typeOfValue, F[] fields) {
        Iterator<Response> iterator = response.iterator();
        Map<F, V> map = new LinkedHashMap<>();
        for (F field : fields) {
            Response v = iterator.next();
            map.put(field, decode(typeOfValue, v));
        }
        return map;
    }

The JDK compiles code as

final <F, V> Map<F, V> decodeAsOrderedMap(Response response, Class<V> typeOfValue, F[] fields) {
        Iterator<Response> iterator = response.iterator();
        Map<F, V> map = new LinkedHashMap();
        Object[] var6 = fields;
        int var7 = fields.length;

        for(int var8 = 0; var8 < var7; ++var8) {
            F field = var6[var8];
            Response v = (Response)iterator.next();
            map.put(field, this.decode(typeOfValue, v));
        }

        return map;
    }

Here is my test code

HashCommands<String, String, String> infoHashCommands = redisDs.hash(String.class, String.class, String.class);
        infoHashCommands.hmget("", code, code2);

if the code parameter is null,it will caused ArrayIndexOutOfBoundsException

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @Ladicek (redis), @cescoffier (redis), @machi1990 (redis)

[cescoffier]

Do you have some code reproducing this issue?

Also, check your redis server version.

[Awen92]

Do you have some code reproducing this issue?

Also, check your redis server version.

Here was my test code

HashCommands<String, String, String> infoHashCommands = redisDs.hash(String.class, String.class, String.class);
infoHashCommands.hmget("", code, code2);

Pass the code parameter as null object, you can reproduce this issue

[cescoffier]

Ah ok, you pass 'null'. I don't believe it should be possible (I will check). Anyway, the error message is incorrect.

[cescoffier]

So as indicated on https://redis.io/docs/latest/commands/hmget/, fields cannot contain null values. I will update the code to check for that and throw a more accurate error message.

[cescoffier]

Opened #42142 to improve the error message.