Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on hibernate.highlight_sql #40921

Closed
gavinking opened this issue May 31, 2024 · 4 comments · Fixed by #40954
Closed

turn on hibernate.highlight_sql #40921

gavinking opened this issue May 31, 2024 · 4 comments · Fixed by #40954
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request
Milestone

Comments

@gavinking
Copy link

Description

Quarkus does not appear to give me a way to enable hibernate.highlight_sql, making the logged SQL difficult to read.

Since Quarkus already highlights log messages by default, I would actually just turn this setting on by default.

Implementation ideas

No response

@gavinking gavinking added the kind/enhancement New feature or request label May 31, 2024
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels May 31, 2024
Copy link

quarkus-bot bot commented May 31, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@Eng-Fouad
Copy link
Contributor

Have you tried quarkus.hibernate-orm.unsupported-properties."hibernate.highlight_sql"=ture?

@gavinking
Copy link
Author

Have you tried quarkus.hibernate-orm.unsupported-properties."hibernate.highlight_sql"=ture?

What I'm saying is that this property setting should not only be "supported", it should be turned on by default (at least in dev mode).

And it should be named quarkus.hibernate-orm.log.highlight-sql to match quarkus.hibernate-orm.log.format-sql.

@geoand
Copy link
Contributor

geoand commented Jun 4, 2024

Cool feature!

#40954 adds support for it

geoand added a commit that referenced this issue Jun 4, 2024
Highlight Hibernate generated SQL queries
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants