Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Vert.x Buffer.toJson() method with Buffer.toJsonValue() #39712

Closed
cescoffier opened this issue Mar 26, 2024 · 3 comments · Fixed by #40695
Closed

Replace Vert.x Buffer.toJson() method with Buffer.toJsonValue() #39712

cescoffier opened this issue Mar 26, 2024 · 3 comments · Fixed by #40695
Labels
area/vertx kind/bug Something isn't working
Milestone
3.12.0.CR1

Comments

@cescoffier
Copy link
Member

Describe the bug

It's not really a bug, but currently, Quarkus uses a deprecated method: Buffer.toJson(). This method will be removed at some point. It was replaced with Buffer.toJsonValue(). We should replace our calls.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@cescoffier cescoffier added the kind/bug Something isn't working label Mar 26, 2024
@geoand
Copy link
Contributor

geoand commented Mar 27, 2024

Are you sure we are using it?

My IDE could not find any usages of io.vertx.core.buffer.Buffer#toJson or io.vertx.mutiny.core.buffer.Buffer#toJson

@cescoffier
Copy link
Member Author

I think we use it in Redis.

That being said, I may already have made the change - I just forgot.

@geoand
Copy link
Contributor

geoand commented Mar 27, 2024 •
edited
Loading

Very likely :)

geoand added a commit to geoand/quarkus that referenced this issue May 17, 2024
@geoand
Replace Buffer.toJson with Buffer.toJsonValue
399b7a8 
Fixes: quarkusio#39712
@geoand geoand mentioned this issue May 17, 2024
Merged
cescoffier added a commit that referenced this issue May 19, 2024
@cescoffier
Merge pull request #40695 from geoand/#39712
f020580
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 19, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
@geoand @holly-cummins
Replace Buffer.toJson with Buffer.toJsonValue
a11e57c 
Fixes: quarkusio#39712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/vertx kind/bug Something isn't working
Projects
None yet
Milestone
3.12.0.CR1
Development

Successfully merging a pull request may close this issue.

Replace Buffer.toJson with Buffer.toJsonValue geoand/quarkus
2 participants
@cescoffier @geoand