Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve track-config-changes performance by delegating dependencies fingerprinting to the Develocity extension #39256

Closed
jprinet opened this issue Mar 7, 2024 · 3 comments · Fixed by #41482
Closed

Improve track-config-changes performance by delegating dependencies fingerprinting to the Develocity extension #39256

jprinet opened this issue Mar 7, 2024 · 3 comments · Fixed by #41482
Assignees
@gsmet
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/enhancement New feature or request
Milestone
3.13.0.CR1

Comments

@jprinet
Copy link
Contributor

jprinet commented Mar 7, 2024

Description

This PR introduced the target/quarkus-<profile-name>-dependency-checksums.txt file which contains the list of Quarkus extra dependencies brought during a Quarkus build.
This file is used in the context of caching.
For SNAPSHOT versions, a fingerprint is computed to be able to track differences among builds.

This fingerprinting would actually be more naturally handled by the Develocity Maven extension.
In details, the Quarkus build caching capability is brought by the Quarkus Maven build caching extension.

This extension is already ready to integrate the fingerprinting currently handled by the Quarkus Maven plugin since this PR.

The required changes are:

  • list dependencies with absolute path
  • create a file named target/quarkus-<profile-name>-dependencies.txt

Implementation ideas

No response
@jprinet jprinet added the kind/enhancement New feature or request label Mar 7, 2024
@jprinet
Copy link
Contributor Author

jprinet commented Mar 7, 2024

cc @aloubyansky

@geoand geoand added area/housekeeping Issue type for generalized tasks not related to bugs or enhancements and removed triage/needs-triage labels Mar 7, 2024
@gsmet gsmet self-assigned this Jun 24, 2024
gsmet added a commit to gsmet/quarkus that referenced this issue Jun 26, 2024
@gsmet
Generate dependency list for Develocity consumption
99f86a2 
We used to build the hashes ourselves but it's best to use the
Develocity infrastructure for that.

Fixes quarkusio#39256
@gsmet gsmet mentioned this issue Jun 26, 2024
Merged
@gsmet
Copy link
Member

gsmet commented Jun 26, 2024

I created #41482 to address this.

gsmet added a commit to gsmet/quarkus that referenced this issue Jun 26, 2024
@gsmet
Generate dependency list for Develocity consumption
2f803cf 
We used to build the hashes ourselves but it's best to use the
Develocity infrastructure for that.

Fixes quarkusio#39256
gsmet added a commit to gsmet/quarkus that referenced this issue Jun 27, 2024
@gsmet
Generate dependency list for Develocity consumption
95d720b 
We used to build the hashes ourselves but it's best to use the
Develocity infrastructure for that.

Fixes quarkusio#39256
gsmet added a commit to gsmet/quarkus-project-develocity-extension that referenced this issue Jun 27, 2024
@gsmet
Take into account quarkus-*-dependencies.txt
be41f09 
Related to:
- quarkusio/quarkus#39256
- quarkusio/quarkus#41482
@gsmet gsmet mentioned this issue Jun 27, 2024
Merged
@gsmet
Copy link
Member

gsmet commented Jun 27, 2024

@jprinet I also created quarkusio/quarkus-project-develocity-extension#32 if you want to have a look?

@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jun 27, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
@gsmet @holly-cummins
Generate dependency list for Develocity consumption
a5b7690 
We used to build the hashes ourselves but it's best to use the
Develocity infrastructure for that.

Fixes quarkusio#39256
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
@gsmet @danielsoro
Generate dependency list for Develocity consumption
969fa04 
We used to build the hashes ourselves but it's best to use the
Develocity infrastructure for that.

Fixes quarkusio#39256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsmet gsmet

Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements kind/enhancement New feature or request
Projects
None yet
Milestone
3.13.0.CR1
Development

Successfully merging a pull request may close this issue.

Generate dependency list for Develocity consumption gsmet/quarkus
3 participants
@gsmet @geoand @jprinet