Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "extension-status" tag in guides #37941

Closed
albers opened this issue Dec 27, 2023 · 4 comments · Fixed by #38001
Closed

Missing "extension-status" tag in guides #37941

albers opened this issue Dec 27, 2023 · 4 comments · Fixed by #38001
Labels
area/documentation kind/bug Something isn't working
Milestone

Comments

@albers
Copy link
Contributor

albers commented Dec 27, 2023

Describe the bug

Two guides have an unresolved extension-status variable:

leading to this output

This technology is considered {extension-status}.

This happens because the template extension-status.adoc is included without the variable extension-status being defined.

The two docs seem to be the only ones suffering from this problem:

$ grep -Fl 'include::{includes}/extension-status.adoc[]' docs/src/main/asciidoc/*.adoc | xargs grep -L ^:extension-status:
docs/src/main/asciidoc/cache.adoc
docs/src/main/asciidoc/security-oauth2.adoc

Expected behavior

The variable is resolved to an output such as This technology is considered experimental.
Status specific information from the included template is displayed.

Actual behavior

The variable is not resolved.
The included template content collapses to its minimal output.

How to Reproduce?

Follow the links to the docs and take a look at the text right to the first blue info icon.

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

If someone could be so kind to provide the correct extension status here, I can provide a PR with a fix.

@albers albers added the kind/bug Something isn't working label Dec 27, 2023
@melloware
Copy link
Contributor

cc @holly-cummins

@geoand
Copy link
Contributor

geoand commented Jan 3, 2024

Thanks for spotting this!

@sberyozkin what is the status of security-oauth2? I assume it's stable

@geoand
Copy link
Contributor

geoand commented Jan 3, 2024

Nevermind, #37999 takes care of it

Copy link

quarkus-bot bot commented Jan 3, 2024

/cc @MichalMaler (documentation), @ebullient (documentation), @inoxx03 (documentation), @michelle-purcell (documentation), @rolfedh (documentation), @sheilamjones (documentation), @sunayna15 (documentation)

geoand added a commit to geoand/quarkus that referenced this issue Jan 3, 2024
gsmet added a commit that referenced this issue Jan 3, 2024
Fix the status is a couple extensions documentation pages
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Jan 3, 2024
@gsmet gsmet modified the milestones: 3.7 - main, 3.6.5 Jan 9, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation kind/bug Something isn't working
Projects
4 participants