Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of Embedded and ManyToOne nested object projection + Support of @ProjectedFieldName on class fields #36581

Closed
humcqc opened this issue Oct 19, 2023 · 10 comments · Fixed by #36594
Closed

Support of Embedded and ManyToOne nested object projection + Support of @ProjectedFieldName on class fields #36581

humcqc opened this issue Oct 19, 2023 · 10 comments · Fixed by #36594
Labels
area/panache kind/enhancement New feature or request
Milestone
3.9.0.CR1

Comments

@humcqc
Copy link
Contributor

humcqc commented Oct 19, 2023 •
edited
Loading

Description

  1. Add support of @Embedded and @XXXToOne nested objects in panache query projection.

  2. When you use Lombok for DTO, it could be helpfull to have the @ProjectedFieldName annotation available for fields instead of constructor parameters.

Implementation ideas

Add support in CommonPanacheQueryImpl#project
@humcqc humcqc added the kind/enhancement New feature or request label Oct 19, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 20, 2023

/cc @FroMage (panache), @loicmathieu (panache)

humcqc added a commit to humcqc/quarkus that referenced this issue Oct 20, 2023
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
85764b1 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Oct 20, 2023
@humcqc
quarkusio#36581 Update comments
6c3da7b
@humcqc
Copy link
Contributor Author

humcqc commented Oct 20, 2023 •
edited
Loading

Hi @FroMage , @loicmathieu
Could you check a first try in PR: #36594 ?
If ok I will impact the documentation.

Thanks

humcqc added a commit to humcqc/quarkus that referenced this issue Oct 21, 2023
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
7aa18be 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Oct 21, 2023
@humcqc
quarkusio#36581 Update comments
3ec1add
@humcqc
Copy link
Contributor Author

humcqc commented Oct 30, 2023

Hi @FroMage , @loicmathieu, @yrodiere
Any chance someone can have a look?
Without this i cannot use projection and need to use mapstruct that is less efficient
Thanks

@yrodiere
Copy link
Member

I don't have time for this, sorry. Maybe somebody else will. In any case, I'm sure @FroMage accepts pull requests :)

@humcqc
Copy link
Contributor Author

humcqc commented Nov 10, 2023

Hello, @FroMage @loicmathieu any possible update ?

@humcqc
Copy link
Contributor Author

humcqc commented Nov 14, 2023

Hello @yrodiere , should I add other people to have a chance for this to move forward ? Seems @FroMage and @loicmathieu doesn't have time to look at this. Is there anything I can do to unblock ?

@yrodiere
Copy link
Member

Is there anything I can do to unblock ?

Yes, you can work with the Panache maintainers (i.e. not me, but @FroMage or maybe @loicmathieu or someone else) to provide a pull request yourself.

@humcqc
Copy link
Contributor Author

humcqc commented Nov 14, 2023 •
edited
Loading

Thanks @yrodiere!
@FroMage , @loicmathieu any chance to have some feedback ?

@loicmathieu
Copy link
Contributor

Hi @humcqc,
Sorry for the late feedback; your PR somehow goes under my radar. I'll try to have a look this week.

humcqc added a commit to humcqc/quarkus that referenced this issue Nov 15, 2023
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
8a09e97 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 15, 2023
@humcqc
quarkusio#36581 Update comments
48777f9
@humcqc
Copy link
Contributor Author

humcqc commented Nov 16, 2023

Thanks @loicmathieu

humcqc added a commit to humcqc/quarkus that referenced this issue Nov 17, 2023
@humcqc
quarkusio#36581 review with @loicmathieu
cf63b8b 
Add simple test/example with DogDto2
Rename annotation
Add documentation
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 17, 2023
@humcqc
quarkusio#36581 revert bad commit
2c62cdd
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 17, 2023
@humcqc
quarkusio#36581 tested with JDK 11, no issue :( + remove System.out c…
c00028b 
…ommitted by mistake.
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
761e0d9 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 Update comments
4ebcc9a
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 review with @loicmathieu
022a6a8 
Add simple test/example with DogDto2
Rename annotation
Add documentation
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 revert bad commit
0a42647
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 tested with JDK 11, no issue :( + remove System.out c…
5d4db92 
…ommitted by mistake.
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 fix Jdk 11 test + native Data 3 and 7
5c555d8
humcqc added a commit to humcqc/quarkus that referenced this issue Nov 28, 2023
@humcqc
quarkusio#36581 Simplify test, apply @loicmatthieu comments.
16db411
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 28, 2024
@humcqc
quarkusio#36581 fix Jdk 11 test + native Data 3 and 7
60d2844
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 28, 2024
@humcqc
quarkusio#36581 Simplify test, apply @loicmatthieu comments.
cba4a25
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 28, 2024
@humcqc
quarkusio#36581 Add @DisabledOnIntegrationTest like other tests
3dd3957
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
3c62c50 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 Update comments
3fcb98d
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 review with @loicmathieu
61122e1 
Add simple test/example with DogDto2
Rename annotation
Add documentation
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 revert bad commit
1ca9678
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 tested with JDK 11, no issue :( + remove System.out c…
90a5943 
…ommitted by mistake.
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 fix Jdk 11 test + native Data 3 and 7
fd1e2c3
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 Simplify test, apply @loicmatthieu comments.
8fcbf80
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 30, 2024
@humcqc
quarkusio#36581 Add @DisabledOnIntegrationTest like other tests
2f5d35d
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
28d631f 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Update comments
11c3c36
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 review with @loicmathieu
ab54873 
Add simple test/example with DogDto2
Rename annotation
Add documentation
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 revert bad commit
da3acec
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 tested with JDK 11, no issue :( + remove System.out c…
650991f 
…ommitted by mistake.
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 fix Jdk 11 test + native Data 3 and 7
1f86b1c
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Simplify test, apply @loicmatthieu comments.
445a003
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Add @DisabledOnIntegrationTest like other tests
3882775
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Support of Embedded and ManyToOne nested object proje…
2e2f9aa 
…ction + Support of @ProjectedFieldName on class fields
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Update comments
e3dc995
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 review with @loicmathieu
0a25c0e 
Add simple test/example with DogDto2
Rename annotation
Add documentation
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 revert bad commit
8c083e3
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 tested with JDK 11, no issue :( + remove System.out c…
41ff528 
…ommitted by mistake.
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 fix Jdk 11 test + native Data 3 and 7
9bd892a
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Simplify test, apply @loicmatthieu comments.
3c60857
humcqc added a commit to humcqc/quarkus that referenced this issue Jan 31, 2024
@humcqc
quarkusio#36581 Add @DisabledOnIntegrationTest like other tests
e7910ec
@humcqc humcqc closed this as completed Feb 1, 2024
@yrodiere yrodiere mentioned this issue Feb 1, 2024
Merged
@yrodiere yrodiere added this to the 3.9 - main milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/panache kind/enhancement New feature or request
Projects
None yet
Milestone
3.9.0.CR1
4 participants
@yrodiere @loicmathieu @geoand @humcqc