Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestEasy Reactive Rest Client captures thread stack and there is no option to disable it #36092

Closed
umutsahin opened this issue Sep 22, 2023 · 3 comments · Fixed by #36093
Closed

RestEasy Reactive Rest Client captures thread stack and there is no option to disable it #36092

umutsahin opened this issue Sep 22, 2023 · 3 comments · Fixed by #36093
Assignees
@geoand
Labels
area/rest area/rest-client kind/enhancement New feature or request
Milestone
3.5.0.CR1

Comments

@umutsahin
Copy link

Description

Hi,

While profiling our quarkus application, which using RestEasy reactive rest client, I have noticed it is recording thread stacks.
Checked the code but unfortunately there is no option to disable this feature.

I fear this is degrading performance for the client.

Involved classes:

  • org.jboss.resteasy.reactive.client.handlers.ClientCaptureCurrentContextRestHandler
  • org.jboss.resteasy.reactive.client.impl.HandlerChain
Screenshot 2023-09-22 at 11 35 22

Implementation ideas

There should be an option to disable this feature, for performance demanding applications this is crucial.
@umutsahin umutsahin added the kind/enhancement New feature or request label Sep 22, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 22, 2023

/cc @FroMage (resteasy-reactive), @cescoffier (rest-client), @geoand (rest-client,resteasy-reactive), @stuartwdouglas (resteasy-reactive)

@geoand
Copy link
Contributor

geoand commented Sep 22, 2023

Thanks for reporting. I'll take care of this

@geoand geoand self-assigned this Sep 22, 2023
geoand added a commit to geoand/quarkus that referenced this issue Sep 22, 2023
@geoand
Add config property for disabling REST Client stacktrace capture
9b08ab6 
Closes: quarkusio#36092
@geoand geoand mentioned this issue Sep 22, 2023
Merged
@geoand
Copy link
Contributor

geoand commented Sep 22, 2023

#36093 takes of the issue

geoand added a commit that referenced this issue Sep 22, 2023
@geoand
Merge pull request #36093 from geoand/#36092
d98090e 
Add config property for disabling REST Client stacktrace capture
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 22, 2023
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Feb 8, 2024
@geoand @holly-cummins
Add config property for disabling REST Client stacktrace capture
0153cc9 
Closes: quarkusio#36092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/rest area/rest-client kind/enhancement New feature or request
Projects
None yet
Milestone
3.5.0.CR1
Development

Successfully merging a pull request may close this issue.

Add config property for disabling REST Client stacktrace capture geoand/quarkus
2 participants
@geoand @umutsahin