-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate annotation for class: interface io.smallrye.common.annotation.CheckReturnValue #35715
Comments
/cc @Ladicek (smallrye), @jmartisk (smallrye), @phillip-kruger (smallrye), @radcortez (smallrye) |
Same here and this is the culprit
|
@mklueh i dont know what it was but i set the project up new, and now it works. i had to learn a few tweaks but i got it to work. if you want i can help you try to solve it. |
@PartyBuzzProject glad to hear. thanks |
@PartyBuzzProject - can you mention how you solved it? I am facing the same issue |
@go-neta so in my case i wanted to use flyway so i had a jdbc driver besides the reactive driver and i now managed to remove the jdbc driver dependency and disable jdbc and write my own execution of flyway that currently looks like this:
its not worked out by now. so i need to add validation but im in early stage of development. hopefully that helps :) |
thanks for the update. |
I have no idea. i think i also have too little experience with quarkus. |
It would be nice if all people encountering this issue could provide a small reproducer project so that we can see the commonalities (might be a Gradle or Kotlin specific issue for instance). Thanks. |
IMO it would be great if you had a full test project ( Multi Module Gradle + Kotlin ) that at least automatically verifies the compatibility between Quarkus dependencies, so users would not have to create dozens of reproducer projects and you would detect such issues before releasing a new version. And then maybe people could check it out and add their individual issue (if it's something new and undetected) and you'll have it in your test suite as well, and over time you'd have more and more real-world usages you verify against. |
@gsmet I have added a zip of my project in this issue. |
@mklueh this is open source, you're welcome to contribute. |
@jponge @cescoffier do you know who I could ping for this issue? |
@gsmet I'll have a look at the zip file. At first sight the issue report is only a very partial stack trace with no context. |
I am facing the issue in the test environment. My current test is failing on this line:
Project set up:
I hope this is enough information. Let me know if you need more details |
I've been able to reproduce the error, but I don't know where that double annotation comes from |
I'm not familiar with this area of Quarkus, but I suspect the issue comes from |
@nenros The issue is that in this case we have the annotation being added to these 2 methods:
where Note that |
I changed the hibernate reactive library from this |
Excellent analysis! Sounds like an easy fix in that case, no? |
I'll have a look at a fix, because the problem happens with inheritance so it's not just about looking at wether the annotation is present or not ;-) |
Interesting :) |
Hold on, but why would having the annotation on a method of a subclass cause the problem? |
Let me try something real quick |
* We don't add it if it's already there * We don't run the transformation twice Fixes: quarkusio#35715
Turns out the problem was easy enough to fix: #36038 |
* We don't add it if it's already there * We don't run the transformation twice Fixes: quarkusio#35715
* We don't add it if it's already there * We don't run the transformation twice Fixes: quarkusio#35715 (cherry picked from commit 88f0f1c)
* We don't add it if it's already there * We don't run the transformation twice Fixes: quarkusio#35715
Describe the bug
rest.zip
Expected behavior
No response
Actual behavior
How to Reproduce?
No response
Output of
uname -a
orver
No response
Output of
java -version
No response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --version
orgradlew --version
)No response
Additional information
No response
The text was updated successfully, but these errors were encountered: