Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VertxPoolMetrics should count rejected requests #35540

Closed
ahus1 opened this issue Aug 24, 2023 · 2 comments · Fixed by #35541
Closed

VertxPoolMetrics should count rejected requests #35540

ahus1 opened this issue Aug 24, 2023 · 2 comments · Fixed by #35541
Labels
area/metrics area/smallrye kind/enhancement New feature or request
Milestone
3.2.8.Final

Comments

@ahus1
Copy link
Contributor

ahus1 commented Aug 24, 2023

Description

The VertxPoolMetrics currently expose metrics about worker_pool_completed_total, but no counter about rejected submissions to the worker pool.

As discussed in #34998 theExecutorService can be configured with a maximum queue length as a simple mean to load shedding. In those situations it is helpful to have a metric about rejected submissions.

Implementation ideas

Add a new counter rejected to VertxPoolMetrics. I'll prepare a PR for this.
@ahus1 ahus1 added the kind/enhancement New feature or request label Aug 24, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 24, 2023

/cc @ebullient (metrics), @jmartisk (metrics)

ahus1 added a commit to ahus1/quarkus that referenced this issue Aug 24, 2023
@ahus1
Add a metric for rejected submissions to the pool
ff67f70 
Closes quarkusio#35540
This was referenced Aug 24, 2023
Merged
Closed
@ahus1
Copy link
Contributor Author

ahus1 commented Aug 24, 2023

Created a PR: #35541

@quarkus-bot quarkus-bot bot added this to the 3.4 - main milestone Aug 25, 2023
@gsmet gsmet modified the milestones: 3.4 - main, 3.3.1 Aug 26, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 26, 2023
@ahus1 @gsmet
Add a metric for rejected submissions to the pool
5b40039 
Closes quarkusio#35540

(cherry picked from commit ff67f70)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Aug 26, 2023
@ahus1 @gsmet
Add a metric for rejected submissions to the pool
e0aad4e 
Closes quarkusio#35540

(cherry picked from commit ff67f70)
@aloubyansky aloubyansky modified the milestones: 3.3.1, 3.2.8.Final Oct 31, 2023
aloubyansky pushed a commit to aloubyansky/quarkus that referenced this issue Oct 31, 2023
@ahus1 @aloubyansky
Add a metric for rejected submissions to the pool
7613239 
Closes quarkusio#35540

(cherry picked from commit ff67f70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/metrics area/smallrye kind/enhancement New feature or request
Projects
None yet
Milestone
3.2.8.Final
Development

Successfully merging a pull request may close this issue.

Add a metric for rejected submissions to the pool ahus1/quarkus
3 participants
@aloubyansky @gsmet @ahus1