How support multiple tenant root with hibernate6 ?

[seepine]

Description

In Springboot

application.yml

spring:
  jpa:
    properties:
      hibernate:
        multiTenancy: true
        tenant_identifier_resolver: com.example.config.TenantResolver

TenantResolver.java

public interface CurrentTenantIdentifierResolver {
        // set tenant value
	String resolveCurrentTenantIdentifier();
   
        // true will query all tenant data
	default boolean isRoot(String tenantId) {
		return false;
	}
}

But in Quarkus 3.x

I can not find how to query ignore tenant like CurrentTenantIdentifierResolver .isRoot

application.properties

quarkus.hibernate-orm.multitenant=DISCRIMINATOR

CustomTenantResolver.java

@PersistenceUnitExtension
@RequestScoped
public class CustomTenantResolver implements TenantResolver {

  // what is this ?
  @Override
  public String getDefaultTenantId() {
    return "0";
  }

  @Override
  public String resolveTenantId() {
    return Optional.ofNullable(TenantUtil.getTenantId()).map(Serializable::toString).orElse(null);
  }
}

Implementation ideas

like this

        // true will query all tenant data
	default boolean isRoot(String tenantId) {
		return false;
	}

[quarkus-bot]

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

[yrodiere]

Thanks for reporting.

Note: this relates to #35332

Quoting my comment there; a PR solving this would need to:

• add the missing method to io.quarkus.hibernate.orm.runtime.tenant.TenantResolver

• implement isRoot() in

  quarkus/extensions/hibernate-orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/tenant/HibernateCurrentTenantIdentifierResolver.java

  Line 18 in d7b4c51

  public final class HibernateCurrentTenantIdentifierResolver implements CurrentTenantIdentifierResolver {

• add a simple test (checking you have access to all tenants) in integration-tests/hibernate-orm-tenancy/discriminator/src/main/java/io/quarkus/it/hibernate/multitenancy/fruit/CustomTenantResolver.java / integration-tests/hibernate-orm-tenancy/discriminator/src/main/java/io/quarkus/it/hibernate/multitenancy/fruit/FruitResource.java / integration-tests/hibernate-orm-tenancy/discriminator/src/test/java/io/quarkus/it/hibernate/multitenancy/fruit/HibernateTenancyFunctionalityTest.java

[dengchaofeng]

When will this issue be merged into version 3.2. x? As far as I know, version 3.2 is the LTS version

[yrodiere]

As a rule we don't backport new features and enhancements.

That being said, @gsmet asked if someone wanted this backported, exceptionally. But he got no answer, so there are no plans to backport at the moment. I doubt he'd want to backport to 3.2 anyway, but who knows.

[dengchaofeng]

I understand that this is a bug and not a new feature.

[yrodiere]

I understand that this is a bug and not a new feature.

The PR itself is called "Support for multi tenancy root mode", and it adds the ability to declare one tenant as the "root", able to access all data. Discriminator multi-tenancy can reasonably be used without it as far as I know, considering no other form of multi-tenancy supports it. Looks like a feature to me.

Anyway, we can argue about the semantics all day, but at the end you'll need someone who actually works on LTS (i.e., not me, possibly @gsmet) to agree to do the work.