Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @ClientFormParam to Reactive REST Client #34477

Closed
Eng-Fouad opened this issue Jul 3, 2023 · 3 comments · Fixed by #34535
Closed

Add @ClientFormParam to Reactive REST Client #34477

Eng-Fouad opened this issue Jul 3, 2023 · 3 comments · Fixed by #34535
Labels
area/rest-client kind/enhancement New feature or request
Milestone
3.3.0.CR1

Comments

@Eng-Fouad
Copy link
Contributor

Eng-Fouad commented Jul 3, 2023 •
edited
Loading

Description

This is analogous to @ClientQueryParam but for @FormParams.

Implementation ideas

No response
@Eng-Fouad Eng-Fouad added the kind/enhancement New feature or request label Jul 3, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 3, 2023

/cc @Sgitario (rest-client), @cescoffier (rest-client), @geoand (rest-client)

@geoand
Copy link
Contributor

geoand commented Jul 3, 2023

Would you like to try to implement this one?

16888b0 should give you a pretty good idea of what needs to be done

@Eng-Fouad Eng-Fouad mentioned this issue Jul 5, 2023
Merged
@Eng-Fouad
Copy link
Contributor Author

@geoand Kindly review the PR, and check if the implementation is correct. Thanks.

Eng-Fouad added a commit to Eng-Fouad/quarkus that referenced this issue Jul 5, 2023
@Eng-Fouad
Merge branch 'main' into quarkusio#34477
427253c
Eng-Fouad added a commit to Eng-Fouad/quarkus that referenced this issue Jul 6, 2023
@Eng-Fouad
Merge branch 'quarkusio:main' into quarkusio#34477
fbb40fc
Sgitario added a commit that referenced this issue Jul 25, 2023
@Sgitario
Merge pull request #34535 from Eng-Fouad/#34477
aef8aba 
Add @ClientFormParam to Reactive REST Client
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/rest-client kind/enhancement New feature or request
Projects
None yet
Milestone
3.3.0.CR1
Development

Successfully merging a pull request may close this issue.

Add @ClientFormParam to Reactive REST Client Eng-Fouad/quarkus
2 participants
@Eng-Fouad @geoand