Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes extension support RollingUpdate config #34047

Closed
naah69 opened this issue Jun 15, 2023 · 6 comments · Fixed by #34179
Closed

kubernetes extension support RollingUpdate config #34047

naah69 opened this issue Jun 15, 2023 · 6 comments · Fixed by #34179
Labels
Milestone

Comments

@naah69
Copy link

naah69 commented Jun 15, 2023

Description

  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 0%
      maxSurge: 100%

Implementation ideas

No response

@naah69 naah69 added the kind/enhancement New feature or request label Jun 15, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2023

/cc @Sgitario (kubernetes), @geoand (kubernetes), @iocanel (kubernetes)

@Sgitario
Copy link
Contributor

It seems this is already supported by Dekorate.
You can make it work by providing the following Dekorate properties:

dekorate.kubernetes.deploymentStrategy=RollingUpdate
dekorate.kubernetes.rollingUpdate.maxUnavailable=0%
dekorate.kubernetes.rollingUpdate.maxSurge=100%

I will update Quarkus to make these properties available using the standard Quarkus Kubernetes configuration.

@naah69
Copy link
Author

naah69 commented Jun 21, 2023

I am using version that is 2.13.x and add the below config in yaml .
It didn't work.

image

1 similar comment
@naah69
Copy link
Author

naah69 commented Jun 21, 2023

I am using version that is 2.13.x and add the below config in yaml .
It didn't work.

image

@Sgitario
Copy link
Contributor

I think you need to use the camel case format for Dekorate.

@Sgitario
Copy link
Contributor

#34179 should take care of this issue.

Sgitario added a commit to Sgitario/quarkus that referenced this issue Jun 23, 2023
@quarkus-bot quarkus-bot bot added this to the 3.3 - main milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants