Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native.image.path have absolute path in generated pom #33630

Closed
maxandersen opened this issue May 26, 2023 · 4 comments · Fixed by #33742
Closed

native.image.path have absolute path in generated pom #33630

maxandersen opened this issue May 26, 2023 · 4 comments · Fixed by #33742
Assignees
Labels
kind/bug Something isn't working triage/buildscan
Milestone

Comments

@geoand
Copy link
Contributor

geoand commented May 26, 2023

I don't really understand this, the file is in the target directory, so why is it a problem?

To be honest, these build scan results aren't looking to useful...

@gsmet
Copy link
Member

gsmet commented May 26, 2023

I think it's worth fixing because the absolute path shouldn't be used anyway. I'll do it.

@gsmet gsmet self-assigned this May 26, 2023
@maxandersen
Copy link
Member Author

@geoand by having absolute paths it is not cacheble. Meaning you will be required to build this even though no changes between builds.

Thus by fixing this (or mark it on in this specific test the file is not important) everyone running with caching enabled can greatly reduce build times locally and in CI.

Given that I do find the build scans useful :)

@geoand
Copy link
Contributor

geoand commented May 26, 2023

🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working triage/buildscan
Projects
None yet
3 participants