Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus kubernetes creates job with unsupported on spec.completionMode #33085

Closed
paloliska opened this issue May 3, 2023 · 2 comments · Fixed by #33086
Closed

quarkus kubernetes creates job with unsupported on spec.completionMode #33085

paloliska opened this issue May 3, 2023 · 2 comments · Fixed by #33086
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@paloliska
Copy link

Describe the bug

Project containing kubernetes and liquibase extensions creates kubernetes.yml deployment file. Liquibase migration scripts are run inside job defined in this file as following:

kind: Job
metadata:
  name: liquibase-mongodb-init
spec:
  completionMode: OnFailure

Kuberentes job specification does not define such completion mode: https://kubernetes.io/docs/concepts/workloads/controllers/job/#completion-mode

Expected behavior

Deployment success

Actual behavior

Deployment to kubernetes failed with
The Job "liquibase-mongodb-init" is invalid: spec.completionMode: Unsupported value: "OnFailure": supported values: "NonIndexed", "Indexed"

How to Reproduce?

  1. create quarkus 3 project with kubernetes and liquibase extensions
  2. build
  3. deploy generated kubernetes.yml

Output of uname -a or ver

Linux palo-liska 6.1.0-1009-oem #9-Ubuntu SMP PREEMPT_DYNAMIC Fri Mar 31 09:59:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

openjdk version "17.0.6" 2023-01-17 OpenJDK Runtime Environment (build 17.0.6+10-Ubuntu-0ubuntu122.04) OpenJDK 64-Bit Server VM (build 17.0.6+10-Ubuntu-0ubuntu122.04, mixed mode, sharing)

GraalVM version (if different from Java)

No response

Quarkus version or git rev

3.0.1.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 7.5.1

Additional information

No response

@paloliska paloliska added the kind/bug Something isn't working label May 3, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 3, 2023

/cc @Sgitario (kubernetes), @geoand (kubernetes), @iocanel (kubernetes)

@Sgitario
Copy link
Contributor

Sgitario commented May 3, 2023

#33086 should fix this issue.
The only workaround I see for you is to provide your Job resource in src/main/kubernetes/common.yml with the correct value.

@quarkus-bot quarkus-bot bot added this to the 3.1 - main milestone May 7, 2023
@gsmet gsmet modified the milestones: 3.1 - main, 3.0.3.Final May 9, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants