Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing method args of RESTEasy Reactive endpoints secured with @PermissionsAllowed to permission constructor #32030

Closed
michalvavrik opened this issue Mar 22, 2023 · 2 comments · Fixed by #32534
Assignees
Milestone

Comments

@michalvavrik
Copy link
Member

michalvavrik commented Mar 22, 2023

Description

Currently passing arguments of method secured with @PermissionsAllowed only works on security checks performed by CDI interceptors as documented here https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/security-authorize-web-endpoints-reference.adoc#permission-annotation.

As mentioned by Stuart Douglas here https://groups.google.com/g/quarkus-dev/c/ADY6k-Kwv-Y/m/83K2mCDzBwAJ, we can make it work for RESTEasy Reactive endpoints too.

Implementation ideas

  • make sure there is eager authentication security check performed in EagerSecurityHandler so that only authenticated requests are handled by this "postponed" security check done after argument serialization
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 22, 2023

/cc @FroMage (resteasy-reactive), @Sgitario (resteasy-reactive), @geoand (resteasy-reactive), @stuartwdouglas (resteasy-reactive)

@michalvavrik
Copy link
Member Author

I opened this issue so that I don't forget to do that. No actions needed from /cc, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant