OpenshiftProcessor throws StackOverflowError on 3.0.0.Alpha6 #31872
Comments
|
Looks like a bug in the vert.x http client indeed. |
|
I tried to reproduce this issue and to me, it's consistently working fine (either using 3.0.0.Alpha6 or 999-SNAPSHOT). |
|
I'm really sorry folks, I'm on PTO and away until Monday. I could only
check the issue on my phone, however I'm unable to identify the problem.
Not sure how the HTTP client implementation can affect this, we have
thorough tests (k8s agnostic) that ensure that all client behave
consistently.
…On Thu, Mar 16, 2023, 13:55 Jose Carvajal ***@***.***> wrote:
I tried to reproduce this issue and to me, it's consistently working fine
(either using 3.0.0.Alpha6 or 999-SNAPSHOT).
However, I think this change ***@***.***
<fabric8io/kubernetes-client@2216980>
might be related, so maybe @vietj <https://github.com/vietj> can help
here (sorry if it's totally unrelated tho).
—
Reply to this email directly, view it on GitHub
<#31872 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXHR3INCFHHVKHUNRJUGTW4MEVZANCNFSM6AAAAAAV4FDYEU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@manusa no worries, you shouldn't even have read this thread, go back to your PTO! |
You made me doubt, so I restarted the job, and I'm happy (?) to report that it fails consistently, it's not a random fluke: https://github.com/quarkusio/quarkus-github-lottery/actions/runs/4428450881/jobs/7786953713
+1 |
|
@gsmet here is a patch you can test vietj/kubernetes-client@3b8ee08 |
|
@vietj unfortunately I wasn't able to reproduce it when deploying locally. There must be something specific to the GitHub Actions network environment. We will try to deploy the patch to GitHub Actions somehow and report back. |
|
@manusa the end warning is similar to errors we see in the e2e tests with vertx. I was also able to reproduce the stack overflow by using a larger POST stream and some artificial wait in the readChunk method - adding System.out.println(new Exception().getStackTrace().length); - was enough to trigger see the growth of the stack and trigger the overflow. It turns out this is what is happening in the e2e tests - https://pipelines.actions.githubusercontent.com/serviceHosts/15be8e7a-97a9-402c-ad30-bbe66fddae95/_apis/pipelines/1/runs/42329/signedlogcontent/11?urlExpires=2023-03-16T21%3A17%3A01.5488581Z&urlSigningMethod=HMACV1&urlSignature=Uhcd9ka3y1xupK44fdHtaa%2BDa8S%2F8C5CKWYlMcdASXc%3D - it's just that the build exception handling isn't making it obvious to the test class. So we'll need a fix to prevent the possibility of ever increasing recursion with large streams. |
|
you can try this patch @gsmet vietj/kubernetes-client@3b8ee08 |
|
@shawkins could you also try the patch ^. I'm currently working on pushing the patch to GitHub Actions and see how it goes. |
|
@gsmet it works for me. |
|
Nice work. The only changes added to the client's master branch (6.6) are bug-fixes, so as soon as we merge @vietj patch we can release a 6.5.1 version. |
|
Let me try to create the PR by cherry-picking Julien's commit |
|
Thank you, @vietj! |
Describe the bug
Since 3.0.0.Alpha6, using quarkus.kubernetes.deploy=true leads to a
StackOverflowError, thenIllegalStateException: Build:quarkus-github-lottery-2 failed! Failed to fetch the input source.3.0.0.Alpha5 worked fine.
Expected behavior
No
StackOverflowError.Actual behavior
See https://github.com/quarkusio/quarkus-github-lottery/actions/runs/4428450881/jobs/7767890656
How to Reproduce?
I don't have a reproducer but here is the project: https://github.com/quarkusio/quarkus-github-lottery/
Command:
mvn clean package -Dquarkus.kubernetes.deploy=true -Dquarkus.native.container-build=true -Dnative -Drevision=${{ github.sha }}
See https://github.com/quarkusio/quarkus-github-lottery/blob/4a0f8d6655025fffa099396854de89d2fc3c1d73/.github/workflows/deploy.yml#L36-L43
Configuration:
See https://github.com/quarkusio/quarkus-github-lottery/blob/4a0f8d6655025fffa099396854de89d2fc3c1d73/src/main/resources/application.properties
Output of
uname -aorverNo response
Output of
java -versionNo response
GraalVM version (if different from Java)
No response
Quarkus version or git rev
No response
Build tool (ie. output of
mvnw --versionorgradlew --version)No response
Additional information
I was affected by #31476 on Alpha4, not sure if this is related.
The text was updated successfully, but these errors were encountered: