-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus universe bom unaligned dependencies #30804
Comments
related to (but distinct from ) #26067 |
That's how they are configured in https://github.com/quarkusio/quarkus/blob/main/bom/application/pom.xml |
There are no code differences between Reactive Streams 1.0.3 and 1.0.4. So we can update. Note that in Quarkus 3, I'm not sure we will continue to manage that dependency, as we are switching to Flow (part of the JDK). |
We'll still have to ship it (e.g., RESTEasy / Reactive Messaging will support both APIs) |
just to be absolutely clear |
If it'a not about a specific misalignment of this kind then, generally, it's ok, unless it actually breaks something. |
I remember a discussion about |
I will close this one. |
FTR yes you can and have complete control of this as you know what dependencies are pulled in by Quarkus universe- if you add the versions to the BOM then, it will be aligned (and the bom should push the upper version) |
Well, I think that's what we have been doing. Except we don't enforce the upper bound. |
Describe the bug
the quarkus universe bom
io.quarkus:quarkus-universe-bom:2.16.1.Final
contains unaligned versionsthat is there are dependencies that are managed at lower versions than a dependency also in the bom requires.
for example (there are many others):
org.reactivestreams:reactive-streams
is managed to version1.0.3
io.smallrye.reactive:mutiny
is managed to version1.9.0
1.9.0
ofio.smallrye.reactive:mutiny
depends onorg.reactivestreams:reactive-streams:1.0.4
Expected behavior
the bom is importable and all dependencies and their transitive dependencies managed by the bom are satisfiable without a dependency version being downgraded.
Actual behavior
artifact dependencies are downgraded.
How to Reproduce?
create a maven project with the
maven-enforcer
and set therequireUpperBounds
rule. import the universe bom in dependencymanagement and all dependencies that are in the bom as dependencies (without their version being defined)run the build to trigger the enforcer.
expect no upper bounds issues (there are lots).
Output of
uname -a
orver
Hal2001
Output of
java -version
jdk-11.0.15+10
GraalVM version (if different from Java)
No response
Quarkus version or git rev
2.16.1.FINAL
Build tool (ie. output of
mvnw --version
orgradlew --version
)maven 3.8.6
Additional information
No response
The text was updated successfully, but these errors were encountered: